From: David Miller <davem@davemloft.net>
To: santoshprasadnayak@gmail.com
Cc: sony.chacko@qlogic.com, rajesh.borundia@qlogic.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/3 v2] netxen: qlogic ethernet : Fix endian bug.
Date: Sun, 11 Mar 2012 23:48:08 -0700 (PDT) [thread overview]
Message-ID: <20120311.234808.1919218898572322534.davem@davemloft.net> (raw)
In-Reply-To: <1331534303-4093-1-git-send-email-santoshprasadnayak@gmail.com>
From: santosh nayak <santoshprasadnayak@gmail.com>
Date: Mon, 12 Mar 2012 12:08:23 +0530
> From: Santosh Nayak <santoshprasadnayak@gmail.com>
>
> Fix endian bug.
>
> Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
This is a very non-trivial patch, therefore the terse commit
message and the lack of any comments in this code is unacceptable.
This commit message is not only terse, it's wrong. You're not
fixing an endian bug, you're fixing several of them.
Explain everything in your commit message.
> req.words[0] = cpu_to_le64(cmd);
> - req.words[1] = cpu_to_le64(ip);
> + memcpy(&req.words[1], &ip, sizeof(u32));
Nobody is going to read that and have any idea why it's correct unless
they happen to be able to discover the long thread you guys had this
past week working out how to do this change correctly.
Putting a comment here for the rest of us mere mortals is therefore
absolutely required.
next prev parent reply other threads:[~2012-03-12 6:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 6:38 santosh nayak
2012-03-12 6:48 ` David Miller [this message]
2012-03-12 6:52 ` santosh prasad nayak
2012-03-12 9:15 ` santosh prasad nayak
2012-03-12 9:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120311.234808.1919218898572322534.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rajesh.borundia@qlogic.com \
--cc=santoshprasadnayak@gmail.com \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®