From: David Miller <davem@davemloft.net>
To: santoshprasadnayak@gmail.com
Cc: sony.chacko@qlogic.com, rajesh.borundia@qlogic.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/3 v2] netxen: qlogic ethernet : Fix endian bug.
Date: Mon, 12 Mar 2012 02:36:59 -0700 (PDT) [thread overview]
Message-ID: <20120312.023659.22154618235290541.davem@davemloft.net> (raw)
In-Reply-To: <CAOD=uF4qUhKRpWerFkouqNgzTNRL7DRu3G0kxgTb2E31Ox-=aA@mail.gmail.com>
From: santosh prasad nayak <santoshprasadnayak@gmail.com>
Date: Mon, 12 Mar 2012 14:45:38 +0530
> Subject: [PATCH 3/3 v2] netxen: qlogic ethernet : Fix endian bug.
>
> Change the datatype of "ip_addr" to __be32 as 'ip' should be in
> big endian format.
>
> Adapter needs "ip address" in big endian format stored at lower 32bit
> of req.word[1]. netxen_config_ipaddr() now receives 'ip' in big endian
> format. To satisfy adapter's need, use memcpy() to copy byte by byte
> of 'ip' into lower 32bit of req.word[1].
>
> Mac address and serial number of adapter need to be in little endian format.
> Change the data type of the related variables to __le32 / __le64 or cast it
> explicitly to __le32 / __le64 depending upon the requirement.
This looks a lot better.
prev parent reply other threads:[~2012-03-12 9:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 6:38 santosh nayak
2012-03-12 6:48 ` David Miller
2012-03-12 6:52 ` santosh prasad nayak
2012-03-12 9:15 ` santosh prasad nayak
2012-03-12 9:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120312.023659.22154618235290541.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rajesh.borundia@qlogic.com \
--cc=santoshprasadnayak@gmail.com \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®