* [PATCH] Staging: rtl8187se: r8180_core.c: Fix spacing issue
@ 2012-03-11 4:56 Andrew Miller
2012-03-13 22:44 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Miller @ 2012-03-11 4:56 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Andrew Miller
Fix spacing coding style issues
Signed-off-by: Andrew Miller <amiller@amilx.com>
---
drivers/staging/rtl8187se/r8180_core.c | 46 +++++++++++++++++--------------
1 files changed, 25 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c
index 05f25eb..6a0c592 100644
--- a/drivers/staging/rtl8187se/r8180_core.c
+++ b/drivers/staging/rtl8187se/r8180_core.c
@@ -2617,28 +2617,32 @@ void watch_dog_adaptive(unsigned long data)
}
static CHANNEL_LIST ChannelPlan[] = {
- {{1,2,3,4,5,6,7,8,9,10,11,
- 36,40,44,48,52,56,60,64},19}, /* FCC */
- {{1,2,3,4,5,6,7,8,9,10,11},11}, /* IC */
- {{1,2,3,4,5,6,7,8,9,10,11,
- 12,13,36,40,44,48,52,56,60,64},21}, /* ETSI */
- {{1,2,3,4,5,6,7,8,9,10,11,
- 12,13,36,40,44,48,52,56,60,64},21}, /* Spain. Change to ETSI. */
- {{1,2,3,4,5,6,7,8,9,10,11,
- 12,13,36,40,44,48,52,56,60,64},21}, /* France. Change to ETSI. */
- {{14,36,40,44,48,52,56,60,64},9}, /* MKK */
- {{1,2,3,4,5,6,7,8,9,10,11,
- 12,13,14, 36,40,44,48,52,56,60,64},22}, /* MKK1 */
- {{1,2,3,4,5,6,7,8,9,10,11,
- 12,13,36,40,44,48,52,56,60,64},21}, /* Israel. */
- {{1,2,3,4,5,6,7,8,9,10,11,
- 12,13,34,38,42,46},17}, /* For 11a , TELEC */
- {{1,2,3,4,5,6,7,8,9,10,11,
- 12,13,14},14}, /* For Global Domain. 1-11:active scan,
+ {{ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11,
+ 36, 40, 44, 48, 52, 56, 60, 64}, 19}, /* FCC */
+ {{ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11}, 11}, /* IC */
+ {{ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11,
+ 12, 13, 36, 40, 44, 48, 52, 56, 60, 64}, 21}, /* ETSI */
+ {{ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11,
+ 12, 13, 36, 40, 44, 48, 52, 56, 60, 64}, 21}, /* Spain. Change
+ * to ETSI. */
+ {{ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11,
+ 12, 13, 36, 40, 44, 48, 52, 56, 60, 64}, 21}, /* France. Change
+ * to ETSI. */
+ {{ 14, 36, 40, 44, 48, 52, 56, 60, 64}, 9}, /* MKK */
+ {{ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11,
+ 12, 13, 14, 36, 40, 44, 48, 52, 56, 60, 64}, 22}, /* MKK1 */
+ {{ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11,
+ 12, 13, 36, 40, 44, 48, 52, 56, 60, 64}, 21}, /* Israel. */
+ {{ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11,
+ 12, 13, 34, 38, 42, 46}, 17}, /* For 11a , TELEC */
+ {{ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11,
+ 12, 13, 14}, 14}, /* For Global Domain. 1-11:active scan,
* 12-14 passive scan. //+YJ, 080626 */
- {{1,2,3,4,5,6,7,8,9,10,11,12,13},13} /* world wide 13: ch1~ch11 active
- * scan, ch12~13 passive //lzm
- * add 080826 */
+ {{ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13}, 13} /* world wide 13:
+ * ch1~ch11 active
+ * scan, ch12~13
+ * passive //lzm
+ * add 080826 */
};
static void rtl8180_set_channel_map(u8 channel_plan,
--
1.7.7.6
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: rtl8187se: r8180_core.c: Fix spacing issue
2012-03-11 4:56 [PATCH] Staging: rtl8187se: r8180_core.c: Fix spacing issue Andrew Miller
@ 2012-03-13 22:44 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2012-03-13 22:44 UTC (permalink / raw)
To: Andrew Miller; +Cc: devel, linux-kernel
On Sat, Mar 10, 2012 at 11:56:38PM -0500, Andrew Miller wrote:
> Fix spacing coding style issues
>
> Signed-off-by: Andrew Miller <amiller@amilx.com>
> ---
> drivers/staging/rtl8187se/r8180_core.c | 46 +++++++++++++++++--------------
> 1 files changed, 25 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c
> index 05f25eb..6a0c592 100644
> --- a/drivers/staging/rtl8187se/r8180_core.c
> +++ b/drivers/staging/rtl8187se/r8180_core.c
> @@ -2617,28 +2617,32 @@ void watch_dog_adaptive(unsigned long data)
> }
>
> static CHANNEL_LIST ChannelPlan[] = {
> - {{1,2,3,4,5,6,7,8,9,10,11,
> - 36,40,44,48,52,56,60,64},19}, /* FCC */
> - {{1,2,3,4,5,6,7,8,9,10,11},11}, /* IC */
> - {{1,2,3,4,5,6,7,8,9,10,11,
> - 12,13,36,40,44,48,52,56,60,64},21}, /* ETSI */
> - {{1,2,3,4,5,6,7,8,9,10,11,
> - 12,13,36,40,44,48,52,56,60,64},21}, /* Spain. Change to ETSI. */
> - {{1,2,3,4,5,6,7,8,9,10,11,
> - 12,13,36,40,44,48,52,56,60,64},21}, /* France. Change to ETSI. */
> - {{14,36,40,44,48,52,56,60,64},9}, /* MKK */
> - {{1,2,3,4,5,6,7,8,9,10,11,
> - 12,13,14, 36,40,44,48,52,56,60,64},22}, /* MKK1 */
> - {{1,2,3,4,5,6,7,8,9,10,11,
> - 12,13,36,40,44,48,52,56,60,64},21}, /* Israel. */
> - {{1,2,3,4,5,6,7,8,9,10,11,
> - 12,13,34,38,42,46},17}, /* For 11a , TELEC */
> - {{1,2,3,4,5,6,7,8,9,10,11,
> - 12,13,14},14}, /* For Global Domain. 1-11:active scan,
> + {{ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11,
> + 36, 40, 44, 48, 52, 56, 60, 64}, 19}, /* FCC */
> + {{ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11}, 11}, /* IC */
> + {{ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11,
> + 12, 13, 36, 40, 44, 48, 52, 56, 60, 64}, 21}, /* ETSI */
> + {{ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11,
> + 12, 13, 36, 40, 44, 48, 52, 56, 60, 64}, 21}, /* Spain. Change
> + * to ETSI. */
> + {{ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11,
> + 12, 13, 36, 40, 44, 48, 52, 56, 60, 64}, 21}, /* France. Change
> + * to ETSI. */
> + {{ 14, 36, 40, 44, 48, 52, 56, 60, 64}, 9}, /* MKK */
> + {{ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11,
> + 12, 13, 14, 36, 40, 44, 48, 52, 56, 60, 64}, 22}, /* MKK1 */
> + {{ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11,
> + 12, 13, 36, 40, 44, 48, 52, 56, 60, 64}, 21}, /* Israel. */
> + {{ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11,
> + 12, 13, 34, 38, 42, 46}, 17}, /* For 11a , TELEC */
> + {{ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11,
> + 12, 13, 14}, 14}, /* For Global Domain. 1-11:active scan,
That's easier to read? Not to me, how about putting them each on one
line? Yes, that makes for longer lines, but it makes more sense, right?
And what's with the first ' ' on each set of numbers?
> * 12-14 passive scan. //+YJ, 080626 */
> - {{1,2,3,4,5,6,7,8,9,10,11,12,13},13} /* world wide 13: ch1~ch11 active
> - * scan, ch12~13 passive //lzm
> - * add 080826 */
> + {{ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13}, 13} /* world wide 13:
> + * ch1~ch11 active
> + * scan, ch12~13
> + * passive //lzm
> + * add 080826 */
That makes the comment impossible to read.
Please be smarter, this is to be done to make it easy for humans, not to
just blindly follow a tool's "warnings".
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-13 22:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-11 4:56 [PATCH] Staging: rtl8187se: r8180_core.c: Fix spacing issue Andrew Miller
2012-03-13 22:44 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®