From: Oliver Neukum <oliver@neukum.org>
To: santosh nayak <santoshprasadnayak@gmail.com>
Cc: mchehab@infradead.org, gregkh@linuxfoundation.org,
khoroshilov@ispras.ru, linux-media@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] [media] staging: Return -EINTR in s2250_probe() if fails to get lock.
Date: Fri, 16 Mar 2012 17:32:17 +0100 [thread overview]
Message-ID: <201203161732.17246.oliver@neukum.org> (raw)
In-Reply-To: <1331915038-11231-1-git-send-email-santoshprasadnayak@gmail.com>
Am Freitag, 16. März 2012, 17:23:58 schrieb santosh nayak:
> From: Santosh Nayak <santoshprasadnayak@gmail.com>
>
> In s2250_probe(), If locking attempt is interrupted by a signal then
> it should return -EINTR after unregistering audio device and making free
> the allocated memory.
>
> At present, if locking is interrupted by signal it will display message
> "initialized successfully" and return success. This is wrong.
Indeed there's a lot wrong here. The idea of having an interruptible
sleep in probe() is arcane. You need a very, very, very good reason for that.
The sane fix is using an uninterruptable sleep here.
Second, while you are at it, fix the error case for no initialization
due to a failing kmalloc(). You need to return -ENOMEM.
Regards
Oliver
next prev parent reply other threads:[~2012-03-16 16:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 16:23 santosh nayak
2012-03-16 16:32 ` Oliver Neukum [this message]
2012-03-16 16:56 ` santosh prasad nayak
2012-03-16 17:59 ` Oliver Neukum
2012-03-17 16:00 ` santosh prasad nayak
2012-03-17 16:20 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203161732.17246.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=khoroshilov@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=santoshprasadnayak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®