From: Oliver Neukum <oliver@neukum.org>
To: santosh prasad nayak <santoshprasadnayak@gmail.com>
Cc: mchehab@infradead.org, gregkh@linuxfoundation.org,
khoroshilov@ispras.ru, linux-media@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] [media] staging: Return -EINTR in s2250_probe() if fails to get lock.
Date: Sat, 17 Mar 2012 17:20:16 +0100 [thread overview]
Message-ID: <201203171720.16945.oliver@neukum.org> (raw)
In-Reply-To: <CAOD=uF6wD1sx2=Rk3ZaxtykBR32_GMsHmiuXuAQP2U_=c-Ytbw@mail.gmail.com>
Am Samstag, 17. März 2012, 17:00:36 schrieb santosh prasad nayak:
> Oliver,
>
> The following changes are for review only not a formal patch.
>
> -------------------------------------------------------------------------------------------------------------
> - if (mutex_lock_interruptible(&usb->i2c_lock) == 0) {
> + mutex_lock(&usb->i2c_lock);
> data = kzalloc(16, GFP_KERNEL);
> - if (data != NULL) {
> + if(data == NULL) {
> + i2c_unregister_device(audio);
> + kfree(state);
> + return -ENOMEM;
> + } else {
> int rc;
> rc = go7007_usb_vendor_request(go, 0x41, 0, 0,
> data, 16, 1);
> @@ -657,7 +661,7 @@ static int s2250_probe(struct i2c_client *client,
> kfree(data);
> }
> mutex_unlock(&usb->i2c_lock);
> - }
> +
>
> ----------------------------------------------------------------------
>
>
> Is it ok ?
Hi,
well done. That's correct.
Regards
Oliver
prev parent reply other threads:[~2012-03-17 16:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 16:23 santosh nayak
2012-03-16 16:32 ` Oliver Neukum
2012-03-16 16:56 ` santosh prasad nayak
2012-03-16 17:59 ` Oliver Neukum
2012-03-17 16:00 ` santosh prasad nayak
2012-03-17 16:20 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203171720.16945.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=khoroshilov@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=santoshprasadnayak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®