* [PATCH] MFD: da9052-i2c - add some section annotations
@ 2012-03-17 23:01 Dmitry Torokhov
2012-03-20 15:39 ` Samuel Ortiz
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Torokhov @ 2012-03-17 23:01 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: linux-kernel
da9052_i2c_remove() can and should be marked as __devexit.
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---
drivers/mfd/da9052-i2c.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/da9052-i2c.c b/drivers/mfd/da9052-i2c.c
index 44b97c7..f99685a 100644
--- a/drivers/mfd/da9052-i2c.c
+++ b/drivers/mfd/da9052-i2c.c
@@ -87,7 +87,7 @@ err:
return ret;
}
-static int da9052_i2c_remove(struct i2c_client *client)
+static int __devexit da9052_i2c_remove(struct i2c_client *client)
{
struct da9052 *da9052 = i2c_get_clientdata(client);
@@ -107,7 +107,7 @@ static struct i2c_device_id da9052_i2c_id[] = {
static struct i2c_driver da9052_i2c_driver = {
.probe = da9052_i2c_probe,
- .remove = da9052_i2c_remove,
+ .remove = __devexit_p(da9052_i2c_remove),
.id_table = da9052_i2c_id,
.driver = {
.name = "da9052",
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] MFD: da9052-i2c - add some section annotations
2012-03-17 23:01 [PATCH] MFD: da9052-i2c - add some section annotations Dmitry Torokhov
@ 2012-03-20 15:39 ` Samuel Ortiz
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Ortiz @ 2012-03-20 15:39 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-kernel
Hi Dmitry,
On Sat, Mar 17, 2012 at 04:01:09PM -0700, Dmitry Torokhov wrote:
> da9052_i2c_remove() can and should be marked as __devexit.
Applied, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-20 15:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-17 23:01 [PATCH] MFD: da9052-i2c - add some section annotations Dmitry Torokhov
2012-03-20 15:39 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®