Re: [PATCH] usb gadget: fix a section mismatch when compiling g_ffs with CONFIG_USB_FUNCTIONFS_ETH

[Felipe Balbi <balbi@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1418 bytes --]

On Wed, Mar 21, 2012 at 12:10:46PM +0100, Lothar Waßmann wrote:
> Hi,
> 
> Felipe Balbi writes:
> > Hi,
> > 
> > On Sun, Mar 11, 2012 at 03:08:46PM +0100, Lothar Waßmann wrote:
> > > Hi,
> > > 
> > > please ignore the previous message. I sent the patch out too early.
> > > Here is a revised version.
> > > 
> > >  commit 28824b18ac4705e876a282a15ea0de8fc957551f:
> > >  |Author: Michal Nazarewicz <m.nazarewicz@samsung.com>
> > >  |Date:   Wed May 5 12:53:13 2010 +0200
> > >  |
> > >  |    USB: gadget: __init and __exit tags removed
> > >  |
> > >  |    __init, __initdata and __exit tags have have been removed from
> > >  |    various files to make it possible for gadgets that do not use
> > >  |    the __init/__exit tags to use those.
> > >  obviously missed (at least) this case leading to a section mismatch in
> > >  g_ffs.c when compiling with CONFIG_USB_FUNCTIONFS_ETH enabled.
> > > 
> > > Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
> > 
> > please send in proper patch format and while at that include any Acks
> > you already got.
> > 
> What's wrong with the format?
> I used git-format-patch to create it, which should produce a properly
> formatted patch AFAIK.

if I try to apply your patch I will have the below on the commit log.

Hi,

please ignore the previous message. I sent the patch out too early.
Here is a revised version.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]