mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Michal Nazarewicz" <mina86@mina86.com>
To: linux-usb@vger.kernel.org, "Lothar Waßmann" <LW@karo-electronics.de>
Cc: "Felipe Balbi" <balbi@ti.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb gadget: fix a section mismatch when compiling g_ffs with CONFIG_USB_FUNCTIONFS_ETH
Date: Sun, 11 Mar 2012 14:51:46 +0100	[thread overview]
Message-ID: <op.wa0d4ki73l0zgt@mpn-glaptop> (raw)
In-Reply-To: <1331472670-28589-1-git-send-email-LW@KARO-electronics.de>

On Sun, 11 Mar 2012 14:31:10 +0100, Lothar Waßmann <LW@karo-electronics.de> wrote:

> commit 28824b18ac4705e876a282a15ea0de8fc957551f:
> |Author: Michal Nazarewicz <m.nazarewicz@samsung.com>
> |Date:   Wed May 5 12:53:13 2010 +0200
> |
> |    USB: gadget: __init and __exit tags removed
> |
> |    __init, __initdata and __exit tags have have been removed from
> |    various files to make it possible for gadgets that do not use
> |    the __init/__exit tags to use those.
> obviously missed (at least) this case leading to a section mismatch in
> g_ffs.c when compiling with CONFIG_USB_FUNCTIONFS_ETH enabled.
>
> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>

Acked-by: Michal Nazarewicz <mina86@mina86.com>

> ---
>  drivers/usb/gadget/f_subset.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/gadget/f_subset.c b/drivers/usb/gadget/f_subset.c
> index c154064..3974bc9 100644
> --- a/drivers/usb/gadget/f_subset.c
> +++ b/drivers/usb/gadget/f_subset.c
> @@ -404,7 +404,7 @@ geth_unbind(struct usb_configuration *c, struct usb_function *f)
>   * Caller must have called @gether_setup().  Caller is also responsible
>   * for calling @gether_cleanup() before module unload.
>   */
> -int __init geth_bind_config(struct usb_configuration *c, u8 ethaddr[ETH_ALEN])
> +int geth_bind_config(struct usb_configuration *c, u8 ethaddr[ETH_ALEN])
>  {
>  	struct f_gether	*geth;
>  	int		status;


-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--

  reply	other threads:[~2012-03-11 13:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-11 13:31 Lothar Waßmann
2012-03-11 13:51 ` Michal Nazarewicz [this message]
2012-03-11 14:08 ` Lothar Waßmann
2012-03-12  5:21   ` Michal Nazarewicz
2012-03-21 10:04   ` Felipe Balbi
2012-03-21 11:10     ` Lothar Waßmann
2012-03-21 11:42       ` Felipe Balbi
2012-03-21 12:35         ` Lothar Waßmann
2012-03-21 14:06 ` [PATCH v2] " Lothar Waßmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=op.wa0d4ki73l0zgt@mpn-glaptop \
    --to=mina86@mina86.com \
    --cc=LW@karo-electronics.de \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®