From: Stephen Hemminger <shemminger@vyatta.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Knut Petersen <Knut_Petersen@t-online.de>,
"David S. Miller" <davem@davemloft.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
arekm@maven.pl, Jared <nitro@legroom.net>,
dilieto@lineone.net, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] sky2: override for PCI legacy power management
Date: Wed, 21 Mar 2012 13:47:25 -0700 [thread overview]
Message-ID: <20120321134725.222e9c07@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <CAErSpo67PEaZ6JuMUntWLfR8SUpQgZERD_cKV6rWd=FF0tZ6DQ@mail.gmail.com>
On Wed, 21 Mar 2012 14:22:01 -0600
Bjorn Helgaas <bhelgaas@google.com> wrote:
> On Wed, Mar 21, 2012 at 9:32 AM, Stephen Hemminger
> <shemminger@vyatta.com> wrote:
> > Some BIOS's don't setup power management correctly (what else is
> > new) and don't allow use of PCI Express power control. Add a special
> > exception module parameter to allow working around this issue.
> > Based on slightly different patch by Knut Petersen.
> >
> > Reported-by: Arkadiusz Miskiewicz <arekm@maven.pl>
> > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
> Is there a problem report URL you can include here?
>
> It looks like this requires a user to figure out that he might be
> suffering from this problem, then use this module parameter to work
> around it. How would a user figure that out? Can we do it
> automatically to save him the trouble?
I am not a power management expert. Looks like a BIOS issue where the
BIOS has configured the device to disable power management but the
user wants to override that value. There is no method to determine
when the BIOS is broken versus when the BIOS setting is correct and
we should follow what it says.
next prev parent reply other threads:[~2012-03-21 20:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 11:40 [REGRESSION][PATCH] Fix an old sky2 WOL regression Knut Petersen
2012-03-21 15:08 ` Stephen Hemminger
2012-03-21 15:32 ` [PATCH] sky2: override for PCI legacy power management Stephen Hemminger
2012-03-21 15:56 ` Knut Petersen
2012-03-21 20:22 ` Bjorn Helgaas
2012-03-21 20:47 ` Stephen Hemminger [this message]
2012-03-21 20:54 ` Bjorn Helgaas
2012-03-22 22:36 ` Knut Petersen
2012-05-06 22:26 ` Jonathan Nieder
2012-03-21 20:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120321134725.222e9c07@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=Knut_Petersen@t-online.de \
--cc=arekm@maven.pl \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=dilieto@lineone.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nitro@legroom.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome