From: Mika Westerberg <mika.westerberg@iki.fi>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Rafal Prylowski <prylowski@metasoft.pl>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"vinod.koul@intel.com" <vinod.koul@intel.com>,
"rmallon@gmail.com" <rmallon@gmail.com>
Subject: Re: [PATCH] ep93xx: Implement double buffering for M2M DMA channels
Date: Fri, 23 Mar 2012 09:04:46 +0200 [thread overview]
Message-ID: <20120323070446.GC5812@mwesterb-mobl.ger.corp.intel.com> (raw)
In-Reply-To: <ADE657CA350FB648AAC2C43247A983F0020696D48E3E@AUSP01VMBX24.collaborationhost.net>
On Thu, Mar 22, 2012 at 09:19:10PM -0500, H Hartley Sweeten wrote:
> Did you test this patch or just review it?
I tested and reviewed it.
> On my system it doesn't work. I think it has something to do with the
> changes to m2m_hw_interrupt but I haven't tracked it down yet.
>
> It looks like what's missing is a:
>
> edmac->edma->hw_submit(edmac);
>
> But, maybe that's not needed with double buffering?
Did you try without your patch and adding my VIC hack? That's what I did when
I first got this patch and I saw no problems. I tested with audio (M2P),
mmc_spi (M2M) and dmatest (M2M).
next prev parent reply other threads:[~2012-03-23 7:05 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 8:09 Rafal Prylowski
2012-03-21 7:07 ` Mika Westerberg
2012-03-21 7:47 ` Rafal Prylowski
2012-03-21 19:33 ` Mika Westerberg
2012-03-21 17:12 ` H Hartley Sweeten
2012-03-21 19:32 ` Mika Westerberg
2012-03-22 0:47 ` H Hartley Sweeten
2012-03-22 7:37 ` Mika Westerberg
2012-03-22 18:52 ` H Hartley Sweeten
2012-03-22 20:03 ` Mika Westerberg
2012-03-22 21:36 ` H Hartley Sweeten
2012-03-22 23:56 ` H Hartley Sweeten
2012-03-23 7:00 ` Mika Westerberg
2012-03-22 10:16 ` Rafal Prylowski
2012-03-21 19:38 ` Mika Westerberg
2012-03-23 2:19 ` H Hartley Sweeten
2012-03-23 7:04 ` Mika Westerberg [this message]
2012-03-23 16:09 ` H Hartley Sweeten
2012-03-24 7:32 ` Mika Westerberg
2012-03-26 6:44 ` Rafal Prylowski
2012-03-29 22:33 ` H Hartley Sweeten
2012-04-01 18:49 ` Mika Westerberg
2012-04-10 17:28 ` Mika Westerberg
2012-04-10 17:55 ` H Hartley Sweeten
2012-04-11 7:18 ` Rafal Prylowski
2012-04-16 18:59 ` H Hartley Sweeten
2012-04-17 7:15 ` Rafal Prylowski
2012-04-17 15:46 ` H Hartley Sweeten
2012-04-17 20:51 ` H Hartley Sweeten
2012-04-18 16:41 ` Rafal Prylowski
2012-04-18 17:01 ` H Hartley Sweeten
2012-03-22 0:57 ` Ryan Mallon
2012-03-22 10:00 ` Rafal Prylowski
2012-03-22 13:14 ` Sergei Shtylyov
2012-03-22 14:13 ` Rafal Prylowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120323070446.GC5812@mwesterb-mobl.ger.corp.intel.com \
--to=mika.westerberg@iki.fi \
--cc=hartleys@visionengravers.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prylowski@metasoft.pl \
--cc=rmallon@gmail.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome