[PATCH 5/5] perf: Fix build error with -Werror in print_event_desc()

[PATCH 5/5] perf: Fix build error with -Werror in print_event_desc()

[David Miller]

'msz' should not be cast to ssize_t when comparing it to
'sz'.  'sz' is a u32 and thus unsigned, just like the type
of 'msz' which is plain size_t.

Signed-off-by: David S. Miller <davem@davemloft.net>
---
 tools/perf/util/header.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
index fcd9cf3..4c7c2d7 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -1177,7 +1177,7 @@ static void print_event_desc(struct perf_header *ph, int fd, FILE *fp)
 		goto error;
 
 	msz = sizeof(attr);
-	if (sz < (ssize_t)msz)
+	if (sz < msz)
 		msz = sz;
 
 	for (i = 0 ; i < nre; i++) {
-- 
1.7.9.1

Re: [PATCH 5/5] perf: Fix build error with -Werror in print_event_desc()

[Arnaldo Carvalho de Melo]

Em Sun, Mar 25, 2012 at 04:28:28PM -0400, David Miller escreveu:
> 
> 'msz' should not be cast to ssize_t when comparing it to
> 'sz'.  'sz' is a u32 and thus unsigned, just like the type
> of 'msz' which is plain size_t.
> 
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
>  tools/perf/util/header.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

This one is already in perf/core:

commit 9fafd98f1bf14276f95b69f0186ad5675f1e1a18
Author: Jiri Olsa <jolsa@redhat.com>
Date:   Tue Mar 20 19:15:39 2012 +0100

    perf tools: Fix various casting issues for 32 bits
 
> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> index fcd9cf3..4c7c2d7 100644
> --- a/tools/perf/util/header.c
> +++ b/tools/perf/util/header.c
> @@ -1177,7 +1177,7 @@ static void print_event_desc(struct perf_header *ph, int fd, FILE *fp)
>  		goto error;
>  
>  	msz = sizeof(attr);
> -	if (sz < (ssize_t)msz)
> +	if (sz < msz)
>  		msz = sz;
>  
>  	for (i = 0 ; i < nre; i++) {
> -- 
> 1.7.9.1