mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Matt Fleming <matt.fleming@intel.com>,
	Trevor Turner <turn3r.tr3v0r@gmail.com>,
	Randy Dunlap <rdunlap@xenotime.net>,
	linux-kernel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: K7/Athlon Optimization Causes Build Fail on Kernel 3.3 i686
Date: Thu, 29 Mar 2012 22:46:23 +0200	[thread overview]
Message-ID: <20120329204622.GA8655@liondog.tnic> (raw)
In-Reply-To: <4F74A9D8.1040808@zytor.com>

On Thu, Mar 29, 2012 at 11:28:40AM -0700, H. Peter Anvin wrote:
> I like this one for urgent as a quick fix, but it doesn't solve the real
> problem which is that boot/compressed shouldn't pick up these macros at all.

But it does through:

<arch/x86/include/asm/string_32.h>:

...
static inline void *__memcpy3d(void *to, const void *from, size_t len)
{
	if (len < 512)
		return __memcpy(to, from, len);
	return _mmx_memcpy(to, from, len);
}

#define memcpy(t, f, n)				\
	(__builtin_constant_p((n))		\
	 ? __constant_memcpy3d((t), (f), (n))	\
	 : __memcpy3d((t), (f), (n)))

> It should be possible to build with MK7 (which is an optimization
> option) and EFI (a functionality option) since they don't inherently
> conflict.  It just doesn't necessarily have to happen *right now*.

I know, technically it is doable, but do you see a K7 box with an EFI
firmware? I, at least, don't think so... :-)

Now, if you think that those optimizations could be used on other boxes
which could sport EFI, then that's a whole another question...

-- 
Regards/Gruss,
    Boris.

  reply	other threads:[~2012-03-29 20:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-27 13:56 Trevor Turner
2012-03-27 17:29 ` Randy Dunlap
2012-03-28  0:03   ` Trevor Turner
2012-03-28 11:19 ` Borislav Petkov
2012-03-28 16:33   ` Trevor Turner
2012-03-28 17:10     ` Borislav Petkov
2012-03-28 17:13       ` Randy Dunlap
2012-03-28 17:27         ` Borislav Petkov
2012-03-29  7:48           ` Borislav Petkov
2012-03-29  8:14             ` Matt Fleming
2012-03-29 10:48               ` Borislav Petkov
2012-03-29 18:21                 ` Trevor Turner
2012-03-29 18:28                 ` H. Peter Anvin
2012-03-29 20:46                   ` Borislav Petkov [this message]
2012-03-29 20:49                     ` H. Peter Anvin
2012-03-30  7:47                       ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120329204622.GA8655@liondog.tnic \
    --to=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=rdunlap@xenotime.net \
    --cc=turn3r.tr3v0r@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®