Question about the regulator driver

Question about the regulator driver

[Kim, Milo]

Hello,

I have a question about the regulator driver design.

There is a mfd device including charger and regulator functions.

For supporting DCDC(or BUCK) and LDO functions, the regulator driver is used.
(like setting voltage, current limit and so on)
On the other hand, the charger module is registered as the power supply class driver.

But charging termination voltage and charging current can be configurable in the charger operation.
In that case, is it common to add regulator_ops for the charger ?
Or is it better that charging parameters are set only in the power supply driver ?

I'd like to have your opinion.

Thanks & BR
Milo -

Re: Question about the regulator driver

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

On Thu, Apr 05, 2012 at 05:36:02PM -0700, Kim, Milo wrote:

> But charging termination voltage and charging current can be
> configurable in the charger operation.
> In that case, is it common to add regulator_ops for the charger ?
> Or is it better that charging parameters are set only in the power
> supply driver ?

I'd just do it as part of the power supply driver, these limits are
internal to the charger driver and so there's no real value in exporting
them.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

RE: Question about the regulator driver

[Kim, Milo]

Thanks for your opinion.

Best Regards,
Milo -

> -----Original Message-----
> From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
> Sent: Friday, April 06, 2012 5:42 PM
> To: Kim, Milo
> Cc: linux-kernel@vger.kernel.org
> Subject: Re: Question about the regulator driver
> 
> On Thu, Apr 05, 2012 at 05:36:02PM -0700, Kim, Milo wrote:
> 
> > But charging termination voltage and charging current can be
> > configurable in the charger operation.
> > In that case, is it common to add regulator_ops for the charger ?
> > Or is it better that charging parameters are set only in the power
> > supply driver ?
> 
> I'd just do it as part of the power supply driver, these limits are
> internal to the charger driver and so there's no real value in
> exporting
> them.