From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "W. Trevor King" <wking@drexel.edu>
Cc: devel@linuxdriverproject.org,
"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
Mori Hess <fmhess@users.sourceforge.net>,
open list <linux-kernel@vger.kernel.org>,
Ian Abbott <abbotti@mev.co.uk>
Subject: Re: [PATCH] staging: comedi: ni_tio_internal.h: checkpatch.pl cleanups
Date: Wed, 18 Apr 2012 16:57:14 -0700 [thread overview]
Message-ID: <20120418235714.GC5163@kroah.com> (raw)
In-Reply-To: <122f461c6a9b638022d67567811f4501b2a466b0.1334671099.git.wking@drexel.edu>
On Tue, Apr 17, 2012 at 09:59:35AM -0400, W. Trevor King wrote:
> * Line wrapping to stay under 80 characters.
> * No braces for single statement blocks.
Please break this into 2 different patches.
Only do one thing per patch, that's the correct thing to do.
greg k-h
next prev parent reply other threads:[~2012-04-18 23:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 13:59 W. Trevor King
2012-04-18 23:57 ` Greg Kroah-Hartman [this message]
2012-04-19 1:30 ` [PATCH v2 0/2] " W. Trevor King
2012-04-19 1:30 ` [PATCH v2 1/2] staging: comedi: ni_tio_internal.h: checkpatch.pl line wrapping W. Trevor King
2012-04-19 1:30 ` [PATCH v2 2/2] staging: comedi: ni_tio_internal.h: checkpatch.pl cleanups W. Trevor King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120418235714.GC5163@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=devel@linuxdriverproject.org \
--cc=fmhess@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=wking@drexel.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome