mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "W. Trevor King" <wking@tremily.us>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "W. Trevor King" <wking@tremily.us>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/2] staging: comedi: ni_tio_internal.h: checkpatch.pl cleanups
Date: Wed, 18 Apr 2012 21:30:26 -0400	[thread overview]
Message-ID: <cover.1334798829.git.wking@tremily.us> (raw)
In-Reply-To: <20120418235714.GC5163@kroah.com>

On Wed, Apr 18, 2012 at 04:57:14PM -0700, Greg Kroah-Hartman wrote:
> On Tue, Apr 17, 2012 at 09:59:35AM -0400, W. Trevor King wrote:
> > * Line wrapping to stay under 80 characters.
> > * No braces for single statement blocks.
>
> Please break this into 2 different patches.

Here you go.

> Only do one thing per patch, that's the correct thing to do.

Sorry, I was thinking "fix checkpatch.pl issues" was a single thing.  I
was also thinking that this is the kind of dumb change that has to happen,
but makes walking backwards with `git blame` annoying, so it would be
better to compress it into fewer commits ;).


W. Trevor King (2):
  staging: comedi: ni_tio_internal.h: checkpatch.pl line wrapping
  staging: comedi: ni_tio_internal.h: checkpatch.pl cleanups

 drivers/staging/comedi/drivers/ni_tio_internal.h |   36 +++++++++++++--------
 1 files changed, 22 insertions(+), 14 deletions(-)

-- 
1.7.3.4


  reply	other threads:[~2012-04-19  1:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-17 13:59 [PATCH] " W. Trevor King
2012-04-18 23:57 ` Greg Kroah-Hartman
2012-04-19  1:30   ` W. Trevor King [this message]
2012-04-19  1:30     ` [PATCH v2 1/2] staging: comedi: ni_tio_internal.h: checkpatch.pl line wrapping W. Trevor King
2012-04-19  1:30     ` [PATCH v2 2/2] staging: comedi: ni_tio_internal.h: checkpatch.pl cleanups W. Trevor King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1334798829.git.wking@tremily.us \
    --to=wking@tremily.us \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®