mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sean MacLennan <seanm@seanm.ca>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/staging/rtl8192u/ieee80211/ieee80211_module.c: add missing free_netdev
Date: Sun, 22 Apr 2012 15:25:14 -0400	[thread overview]
Message-ID: <20120422152514.60e66f04@lappy.seanm.ca> (raw)
In-Reply-To: <1335096133-16951-1-git-send-email-Julia.Lawall@lip6.fr>

On Sun, 22 Apr 2012 14:02:13 +0200
Julia Lawall <Julia.Lawall@lip6.fr> wrote:

> From: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> Free dev on failure as done elsewhere in the function.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_module.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
> b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c index
> e3d47bc..82d4bf6 100644 ---
> a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c +++
> b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c @@ -161,7
> +161,7 @@ struct net_device *alloc_ieee80211(int sizeof_priv) if
> (ieee->pHTInfo == NULL) {
>  		IEEE80211_DEBUG(IEEE80211_DL_ERR, "can't alloc
> memory for HTInfo\n");
> -		return NULL;
> +		goto failed;
>  	}
>  	HTUpdateDefaultSetting(ieee);
>  	HTInitializeHTInfo(ieee); //may move to other place.

It looks like the rtl8192e/rtllib_module.c alloc_rtllib has the same
error. They probably where based on the same function.

Cheers,
   Sean

  reply	other threads:[~2012-04-22 19:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-22 12:02 Julia Lawall
2012-04-22 19:25 ` Sean MacLennan [this message]
2012-04-22 19:28   ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120422152514.60e66f04@lappy.seanm.ca \
    --to=seanm@seanm.ca \
    --cc=Julia.Lawall@lip6.fr \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®