* [PATCH] drivers/staging/rtl8192u/ieee80211/ieee80211_module.c: add missing free_netdev
@ 2012-04-22 12:02 Julia Lawall
2012-04-22 19:25 ` Sean MacLennan
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2012-04-22 12:02 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: kernel-janitors, devel, linux-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
Free dev on failure as done elsewhere in the function.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
index e3d47bc..82d4bf6 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
@@ -161,7 +161,7 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
if (ieee->pHTInfo == NULL)
{
IEEE80211_DEBUG(IEEE80211_DL_ERR, "can't alloc memory for HTInfo\n");
- return NULL;
+ goto failed;
}
HTUpdateDefaultSetting(ieee);
HTInitializeHTInfo(ieee); //may move to other place.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drivers/staging/rtl8192u/ieee80211/ieee80211_module.c: add missing free_netdev
2012-04-22 12:02 [PATCH] drivers/staging/rtl8192u/ieee80211/ieee80211_module.c: add missing free_netdev Julia Lawall
@ 2012-04-22 19:25 ` Sean MacLennan
2012-04-22 19:28 ` Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Sean MacLennan @ 2012-04-22 19:25 UTC (permalink / raw)
To: Julia Lawall; +Cc: Greg Kroah-Hartman, devel, kernel-janitors, linux-kernel
On Sun, 22 Apr 2012 14:02:13 +0200
Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Free dev on failure as done elsewhere in the function.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
> b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c index
> e3d47bc..82d4bf6 100644 ---
> a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c +++
> b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c @@ -161,7
> +161,7 @@ struct net_device *alloc_ieee80211(int sizeof_priv) if
> (ieee->pHTInfo == NULL) {
> IEEE80211_DEBUG(IEEE80211_DL_ERR, "can't alloc
> memory for HTInfo\n");
> - return NULL;
> + goto failed;
> }
> HTUpdateDefaultSetting(ieee);
> HTInitializeHTInfo(ieee); //may move to other place.
It looks like the rtl8192e/rtllib_module.c alloc_rtllib has the same
error. They probably where based on the same function.
Cheers,
Sean
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drivers/staging/rtl8192u/ieee80211/ieee80211_module.c: add missing free_netdev
2012-04-22 19:25 ` Sean MacLennan
@ 2012-04-22 19:28 ` Julia Lawall
0 siblings, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2012-04-22 19:28 UTC (permalink / raw)
To: Sean MacLennan
Cc: Julia Lawall, Greg Kroah-Hartman, devel, kernel-janitors, linux-kernel
On Sun, 22 Apr 2012, Sean MacLennan wrote:
> On Sun, 22 Apr 2012 14:02:13 +0200
> Julia Lawall <Julia.Lawall@lip6.fr> wrote:
>
>> From: Julia Lawall <Julia.Lawall@lip6.fr>
>>
>> Free dev on failure as done elsewhere in the function.
>>
>> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>>
>> ---
>> drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
>> b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c index
>> e3d47bc..82d4bf6 100644 ---
>> a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c +++
>> b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c @@ -161,7
>> +161,7 @@ struct net_device *alloc_ieee80211(int sizeof_priv) if
>> (ieee->pHTInfo == NULL) {
>> IEEE80211_DEBUG(IEEE80211_DL_ERR, "can't alloc
>> memory for HTInfo\n");
>> - return NULL;
>> + goto failed;
>> }
>> HTUpdateDefaultSetting(ieee);
>> HTInitializeHTInfo(ieee); //may move to other place.
>
> It looks like the rtl8192e/rtllib_module.c alloc_rtllib has the same
> error. They probably where based on the same function.
Thanks for the pointer. I will take a look.
julia
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-22 19:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-22 12:02 [PATCH] drivers/staging/rtl8192u/ieee80211/ieee80211_module.c: add missing free_netdev Julia Lawall
2012-04-22 19:25 ` Sean MacLennan
2012-04-22 19:28 ` Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®