* [PATCH] drivers/input/tablet/aiptek.c: adjust error-handling code label
@ 2012-04-16 20:44 Julia Lawall
2012-04-24 5:28 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2012-04-16 20:44 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: kernel-janitors, linux-input, linux-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
At the point of this error-handling code, aiptek->urb has been allocated,
and it does not appear to be less necessary to free it here than in the
error-handling code just below.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/input/tablet/aiptek.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/tablet/aiptek.c b/drivers/input/tablet/aiptek.c
index 205d16a..a33d347 100644
--- a/drivers/input/tablet/aiptek.c
+++ b/drivers/input/tablet/aiptek.c
@@ -1856,7 +1856,7 @@ aiptek_probe(struct usb_interface *intf, const struct usb_device_id *id)
if (i == ARRAY_SIZE(speeds)) {
dev_info(&intf->dev,
"Aiptek tried all speeds, no sane response\n");
- goto fail2;
+ goto fail3;
}
/* Associate this driver's struct with the usb interface.
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drivers/input/tablet/aiptek.c: adjust error-handling code label
2012-04-16 20:44 [PATCH] drivers/input/tablet/aiptek.c: adjust error-handling code label Julia Lawall
@ 2012-04-24 5:28 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2012-04-24 5:28 UTC (permalink / raw)
To: Julia Lawall; +Cc: kernel-janitors, linux-input, linux-kernel
On Mon, Apr 16, 2012 at 10:44:52PM +0200, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> At the point of this error-handling code, aiptek->urb has been allocated,
> and it does not appear to be less necessary to free it here than in the
> error-handling code just below.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied, thank you Julia.
>
> ---
> drivers/input/tablet/aiptek.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/tablet/aiptek.c b/drivers/input/tablet/aiptek.c
> index 205d16a..a33d347 100644
> --- a/drivers/input/tablet/aiptek.c
> +++ b/drivers/input/tablet/aiptek.c
> @@ -1856,7 +1856,7 @@ aiptek_probe(struct usb_interface *intf, const struct usb_device_id *id)
> if (i == ARRAY_SIZE(speeds)) {
> dev_info(&intf->dev,
> "Aiptek tried all speeds, no sane response\n");
> - goto fail2;
> + goto fail3;
> }
>
> /* Associate this driver's struct with the usb interface.
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-24 5:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-16 20:44 [PATCH] drivers/input/tablet/aiptek.c: adjust error-handling code label Julia Lawall
2012-04-24 5:28 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®