* [PATCH] media: videobuf2-dma-contig: include header for exported symbols
@ 2012-04-24 23:08 H Hartley Sweeten
2012-04-26 14:08 ` Marek Szyprowski
0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten @ 2012-04-24 23:08 UTC (permalink / raw)
To: Linux Kernel; +Cc: linux-media, pawel, m.szyprowski, kyungmin.park, mchehab
Include the header to pickup the definitions of the exported symbols.
Quiets the following sparse warnings:
warning: symbol 'vb2_dma_contig_memops' was not declared. Should it be static?
warning: symbol 'vb2_dma_contig_init_ctx' was not declared. Should it be static?
warning: symbol 'vb2_dma_contig_cleanup_ctx' was not declared. Should it be static?
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Pawel Osciak <pawel@osciak.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
---
diff --git a/drivers/media/video/videobuf2-dma-contig.c b/drivers/media/video/videobuf2-dma-contig.c
index f17ad98..a1bee6c 100644
--- a/drivers/media/video/videobuf2-dma-contig.c
+++ b/drivers/media/video/videobuf2-dma-contig.c
@@ -15,6 +15,7 @@
#include <linux/dma-mapping.h>
#include <media/videobuf2-core.h>
+#include <media/videobuf2-dma-contig.h>
#include <media/videobuf2-memops.h>
struct vb2_dc_conf {
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH] media: videobuf2-dma-contig: include header for exported symbols
2012-04-24 23:08 [PATCH] media: videobuf2-dma-contig: include header for exported symbols H Hartley Sweeten
@ 2012-04-26 14:08 ` Marek Szyprowski
0 siblings, 0 replies; 2+ messages in thread
From: Marek Szyprowski @ 2012-04-26 14:08 UTC (permalink / raw)
To: 'H Hartley Sweeten', 'Linux Kernel'
Cc: linux-media, pawel, kyungmin.park, mchehab
Hi,
On Wednesday, April 25, 2012 1:08 AM H Hartley Sweeten wrote:
> Include the header to pickup the definitions of the exported symbols.
>
> Quiets the following sparse warnings:
>
> warning: symbol 'vb2_dma_contig_memops' was not declared. Should it be static?
> warning: symbol 'vb2_dma_contig_init_ctx' was not declared. Should it be static?
> warning: symbol 'vb2_dma_contig_cleanup_ctx' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Pawel Osciak <pawel@osciak.com>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>
> diff --git a/drivers/media/video/videobuf2-dma-contig.c b/drivers/media/video/videobuf2-dma-
> contig.c
> index f17ad98..a1bee6c 100644
> --- a/drivers/media/video/videobuf2-dma-contig.c
> +++ b/drivers/media/video/videobuf2-dma-contig.c
> @@ -15,6 +15,7 @@
> #include <linux/dma-mapping.h>
>
> #include <media/videobuf2-core.h>
> +#include <media/videobuf2-dma-contig.h>
> #include <media/videobuf2-memops.h>
>
> struct vb2_dc_conf {
Best regards
--
Marek Szyprowski
Samsung Poland R&D Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-26 14:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-24 23:08 [PATCH] media: videobuf2-dma-contig: include header for exported symbols H Hartley Sweeten
2012-04-26 14:08 ` Marek Szyprowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®