From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
Andi Kleen <ak@linux.intel.com>,
Jean Delvare <khali@linux-fr.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hwmon: coretemp: fix oops on cpu unplug
Date: Mon, 30 Apr 2012 19:19:41 +0300 [thread overview]
Message-ID: <20120430161941.GA3167@otc-wbsnb-06> (raw)
In-Reply-To: <1335799690.2351.100.camel@groeck-laptop>
On Mon, Apr 30, 2012 at 08:28:10AM -0700, Guenter Roeck wrote:
> Hi,
>
> good catch. Couple of problems, though.
>
> First, what number of cores are we talking about ? We should probably
> increase NUM_REAL_CORES as well. Long term, we should get rid of the
> dependency to prevent that problem from happening again, but that is a
> different issue.
It triggered by another bug. Cores on my 10-core processor have ids 0, 1,
2, 8, 9, 16, 17, 18, 24, 25. :-/
No need to change NUM_REAL_CORES at the moment.
> Second, we'll need the same code in get_core_online(). Otherwise the
> platform device can be created for the new core (if the core is
> re-enabled) but will never be deleted.
It has already handled in create_core_data().
--
Kirill A. Shutemov
next prev parent reply other threads:[~2012-04-30 16:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 13:18 Kirill A. Shutemov
2012-04-30 15:28 ` Guenter Roeck
2012-04-30 16:19 ` Kirill A. Shutemov [this message]
2012-04-30 16:59 ` Guenter Roeck
2012-05-01 15:20 ` Guenter Roeck
2012-05-01 21:00 ` Kirill A. Shutemov
2012-05-01 21:25 ` Guenter Roeck
2012-05-02 15:10 ` [PATCH] hwmon: coretemp: use list instead of fixed size array for temp data Kirill A. Shutemov
2012-05-03 5:29 ` [lm-sensors] " R, Durgadoss
2012-05-03 10:04 ` Kirill A. Shutemov
2012-05-03 11:18 ` [PATCH, v2] " Kirill A. Shutemov
2012-05-04 5:41 ` Guenter Roeck
2012-05-04 6:46 ` Kirill A. Shutemov
2012-05-04 13:34 ` Guenter Roeck
2012-05-04 13:42 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120430161941.GA3167@otc-wbsnb-06 \
--to=kirill.shutemov@linux.intel.com \
--cc=ak@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=guenter.roeck@ericsson.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®