From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
Andi Kleen <ak@linux.intel.com>,
Jean Delvare <khali@linux-fr.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hwmon: coretemp: fix oops on cpu unplug
Date: Wed, 2 May 2012 00:00:41 +0300 [thread overview]
Message-ID: <20120501210041.GA10629@otc-wbsnb-06> (raw)
In-Reply-To: <20120501152014.GA2629@ericsson.com>
On Tue, May 01, 2012 at 08:20:14AM -0700, Guenter Roeck wrote:
> On Mon, Apr 30, 2012 at 09:18:01AM -0400, Kirill A. Shutemov wrote:
> > From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
> >
> > coretemp tries to access core_data array beyond bounds on cpu unplug if
> > core id of the cpu if more than NUM_REAL_CORES-1.
> >
> [ ... ]
> >
> > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>
> Looking at it again, you were right. Adding the check to get_core_online()
> doesn't really help as the platform device is per CPU, not per core.
>
> Applied. I'll submit a separate patch to increase NUM_REAL_CORES.
Actually, the problem is bigger.
Documentation/cputopology.txt:
====
2) /sys/devices/system/cpu/cpuX/topology/core_id:
the CPU core ID of cpuX. Typically it is the hardware platform's
identifier (rather than the kernel's). The actual value is
architecture and platform dependent.
====
We should not use core id as an index in an array since it's an arbitrary
number (from kernel POV).
--
Kirill A. Shutemov
next prev parent reply other threads:[~2012-05-01 20:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 13:18 Kirill A. Shutemov
2012-04-30 15:28 ` Guenter Roeck
2012-04-30 16:19 ` Kirill A. Shutemov
2012-04-30 16:59 ` Guenter Roeck
2012-05-01 15:20 ` Guenter Roeck
2012-05-01 21:00 ` Kirill A. Shutemov [this message]
2012-05-01 21:25 ` Guenter Roeck
2012-05-02 15:10 ` [PATCH] hwmon: coretemp: use list instead of fixed size array for temp data Kirill A. Shutemov
2012-05-03 5:29 ` [lm-sensors] " R, Durgadoss
2012-05-03 10:04 ` Kirill A. Shutemov
2012-05-03 11:18 ` [PATCH, v2] " Kirill A. Shutemov
2012-05-04 5:41 ` Guenter Roeck
2012-05-04 6:46 ` Kirill A. Shutemov
2012-05-04 13:34 ` Guenter Roeck
2012-05-04 13:42 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120501210041.GA10629@otc-wbsnb-06 \
--to=kirill.shutemov@linux.intel.com \
--cc=ak@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=guenter.roeck@ericsson.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®