From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Sasha Levin <levinsasha928@gmail.com>,
broonie@opensource.wolfsonicro.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] TWL6040: fix build error
Date: Fri, 11 May 2012 00:20:49 -0700 [thread overview]
Message-ID: <20120511072049.GA9088@core.coreip.homeip.net> (raw)
In-Reply-To: <4FACB9D7.5090100@ti.com>
On Fri, May 11, 2012 at 10:03:51AM +0300, Peter Ujfalusi wrote:
> Hi,
>
> On 05/11/2012 01:49 AM, Paul Gortmaker wrote:
> > On Thu, May 10, 2012 at 2:44 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
> >> Fixes build error due to missing of_property_read_u32.
> >
> > Yes, I saw the same on x86-64 allyesconfig -- which means that in addition to
> > this missing header, it needs to have a Kconfig dependency that limits
> > it to just being enabled on the platforms where it physically is possible to
> > have the hardware. I'm guessing limiting to ARM would be a good start?
>
> Yes it is only usable on ARM, most specifically on OMAP4+ platforms.
> If I make the twl6040 MFD core to depend on ARM (or even on OMAP) this
> won't happen again.
Is there any other errors beside missing include of.h (and extra
of_device.h?). The driver seems to be compiling fine on x86_64 so no
need to limit to ARM only...
Thanks.
--
Dmitry
next prev parent reply other threads:[~2012-05-11 7:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 18:44 Sasha Levin
2012-05-10 22:49 ` Paul Gortmaker
2012-05-11 2:50 ` Sasha Levin
2012-05-11 2:58 ` Paul Gortmaker
2012-05-11 4:27 ` Grant Likely
2012-05-11 12:16 ` Peter Ujfalusi
2012-05-11 7:03 ` Peter Ujfalusi
2012-05-11 7:20 ` Dmitry Torokhov [this message]
2012-05-11 14:03 ` Paul Gortmaker
2012-05-11 15:05 ` Peter Ujfalusi
2012-05-11 15:49 ` Dmitry Torokhov
2012-05-11 16:10 ` Paul Gortmaker
2012-05-13 10:53 ` Mark Brown
2012-05-11 4:03 ` Dmitry Torokhov
2012-05-11 6:58 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120511072049.GA9088@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=broonie@opensource.wolfsonicro.com \
--cc=levinsasha928@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®