mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jeffrin Jose <ahiliation@yahoo.co.in>
Cc: mdharm-usb@one-eyed-alien.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] drivers:Fixed C99 comment issue.
Date: Tue, 15 May 2012 13:19:01 -0700	[thread overview]
Message-ID: <20120515201901.GB23986@kroah.com> (raw)
In-Reply-To: <1337110335-9783-1-git-send-email-ahiliation@yahoo.co.in>

Ok, now I'm going to get picky, so you can get this right and I will
have no excuse to reject your patches :)

First off, your subject: is "odd". You need to specify what you did
better, with a prefix that says so.

So, for this example, it should say:
	Subject: [PATCH 1/3] USB: storage: fixed c99 comment issue

See the "USB: storage:" part?  Having a generic "drivers:" like you did
really doesn't say anything, as over half of the kernel is drivers, and
you really didn't do this for all of that codebase :)

On Wed, May 16, 2012 at 01:02:15AM +0530, Jeffrin Jose wrote:
> Fixed C99 comment issue in drivers/usb/storage/usb.c
> found using checkpatch.pl tool.
> Signed-off-by: Jeffrin Jose <ahiliation@yahoo.co.in>

You need an extra line before the Signed-off-by: line above.

Care to make these changes to all three of your patches and resend them?

thanks,

greg k-h

      reply	other threads:[~2012-05-15 20:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-15 19:32 Jeffrin Jose
2012-05-15 20:19 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120515201901.GB23986@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ahiliation@yahoo.co.in \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdharm-usb@one-eyed-alien.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®