[PATCH 1/3] drivers:Fixed C99 comment issue.

[PATCH 1/3] drivers:Fixed C99 comment issue.

[Jeffrin Jose]

Fixed C99 comment issue in drivers/usb/storage/usb.c
found using checkpatch.pl tool.
Signed-off-by: Jeffrin Jose <ahiliation@yahoo.co.in>
---
 drivers/usb/storage/usb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c
index 2653e73..7ad1a8b 100644
--- a/drivers/usb/storage/usb.c
+++ b/drivers/usb/storage/usb.c
@@ -261,7 +261,7 @@ EXPORT_SYMBOL_GPL(usb_stor_post_reset);
 void fill_inquiry_response(struct us_data *us, unsigned char *data,
 		unsigned int data_len)
 {
-	if (data_len<36) // You lose.
+	if (data_len<36) /* You lose. */
 		return;
 
 	memset(data+8, ' ', 28);
-- 
1.7.10

Re: [PATCH 1/3] drivers:Fixed C99 comment issue.

[Greg KH]

Ok, now I'm going to get picky, so you can get this right and I will
have no excuse to reject your patches :)

First off, your subject: is "odd". You need to specify what you did
better, with a prefix that says so.

So, for this example, it should say:
	Subject: [PATCH 1/3] USB: storage: fixed c99 comment issue

See the "USB: storage:" part?  Having a generic "drivers:" like you did
really doesn't say anything, as over half of the kernel is drivers, and
you really didn't do this for all of that codebase :)

On Wed, May 16, 2012 at 01:02:15AM +0530, Jeffrin Jose wrote:
> Fixed C99 comment issue in drivers/usb/storage/usb.c
> found using checkpatch.pl tool.
> Signed-off-by: Jeffrin Jose <ahiliation@yahoo.co.in>

You need an extra line before the Signed-off-by: line above.

Care to make these changes to all three of your patches and resend them?

thanks,

greg k-h