* [PATCH] usb: gadget: at91_udc: fix endpoint descriptor dereference
@ 2012-05-16 8:23 Nicolas Ferre
2012-05-16 8:37 ` Felipe Balbi
0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Ferre @ 2012-05-16 8:23 UTC (permalink / raw)
To: linux-usb
Cc: linux-arm-kernel, linux-kernel, plagnioj, gregkh, idos, balbi,
Nicolas Ferre
The patch 5a6506f (Update at91_udc to use usb_endpoint_descriptor inside the
struct usb_ep) removes the desc field of struct at91_ep. This convertion had
not been completed which leads to a compilation error.
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Felipe Balbi <balbi@ti.com>
---
drivers/usb/gadget/at91_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c
index 43943aa..1a4430f 100644
--- a/drivers/usb/gadget/at91_udc.c
+++ b/drivers/usb/gadget/at91_udc.c
@@ -475,7 +475,7 @@ static int at91_ep_enable(struct usb_ep *_ep,
unsigned long flags;
if (!_ep || !ep
- || !desc || ep->desc
+ || !desc || ep->ep.desc
|| _ep->name == ep0name
|| desc->bDescriptorType != USB_DT_ENDPOINT
|| (maxpacket = usb_endpoint_maxp(desc)) == 0
--
1.7.10
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: gadget: at91_udc: fix endpoint descriptor dereference
2012-05-16 8:23 [PATCH] usb: gadget: at91_udc: fix endpoint descriptor dereference Nicolas Ferre
@ 2012-05-16 8:37 ` Felipe Balbi
0 siblings, 0 replies; 2+ messages in thread
From: Felipe Balbi @ 2012-05-16 8:37 UTC (permalink / raw)
To: Nicolas Ferre
Cc: linux-usb, linux-arm-kernel, linux-kernel, plagnioj, gregkh, idos, balbi
[-- Attachment #1: Type: text/plain, Size: 534 bytes --]
On Wed, May 16, 2012 at 10:23:07AM +0200, Nicolas Ferre wrote:
> The patch 5a6506f (Update at91_udc to use usb_endpoint_descriptor inside the
> struct usb_ep) removes the desc field of struct at91_ep. This convertion had
> not been completed which leads to a compilation error.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> Cc: Felipe Balbi <balbi@ti.com>
Acked-by: Felipe Balbi <balbi@ti.com>
Greg this should be applied to avoid compile breakages on your usb-next
branch. Sorry for that.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-16 8:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-16 8:23 [PATCH] usb: gadget: at91_udc: fix endpoint descriptor dereference Nicolas Ferre
2012-05-16 8:37 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®