From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Mike Christie <michaelc@cs.wisc.edu>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Lalit Chandivade <lalit.chandivade@qlogic.com>,
Ravi Anand <ravi.anand@qlogic.com>
Subject: Re: Bug in sysfs bin attribute?
Date: Tue, 22 May 2012 23:17:12 -0700 [thread overview]
Message-ID: <20120523061712.GA19773@kroah.com> (raw)
In-Reply-To: <CBE2759B.EEFF%vikas.chaudhary@qlogic.com>
On Tue, May 22, 2012 at 10:38:11PM -0700, Vikas Chaudhary wrote:
>
> We have added sysfs bin_attribute 'fw_dump' in qla4xxx driver.
> Here is patch for same: -
> http://marc.info/?l=linux-scsi&m=133733192809849&w=2
>
>
> In this patch in function qla4_8xxx_sysfs_write_fw_dump() if we print
> string coming in 'char *buf'
> from sysfs attribute it contain value we echo on sysfs attribute 'fw_dump'
> plus some garbage data.
Why are you not using the built-in firmware interface the kernel
provides you? What does it lack that you need here?
greg k-h
next prev parent reply other threads:[~2012-05-23 6:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 5:38 Vikas Chaudhary
2012-05-23 6:17 ` gregkh [this message]
2012-05-23 8:55 ` Vikas Chaudhary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120523061712.GA19773@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=lalit.chandivade@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=ravi.anand@qlogic.com \
--cc=vikas.chaudhary@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome