From: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Mike Christie <michaelc@cs.wisc.edu>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Lalit Chandivade <lalit.chandivade@qlogic.com>,
Ravi Anand <ravi.anand@qlogic.com>
Subject: Re: Bug in sysfs bin attribute?
Date: Wed, 23 May 2012 01:55:36 -0700 [thread overview]
Message-ID: <CBE2A210.EF14%vikas.chaudhary@qlogic.com> (raw)
In-Reply-To: <20120523061712.GA19773@kroah.com>
-----Original Message-----
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>, Mike Christie
<michaelc@cs.wisc.edu>, James Bottomley
<James.Bottomley@HansenPartnership.com>, Lalit Chandivade
<lalit.chandivade@qlogic.com>, Ravi Anand <ravi.anand@qlogic.com>
Subject: Re: Bug in sysfs bin attribute?
>On Tue, May 22, 2012 at 10:38:11PM -0700, Vikas Chaudhary wrote:
>>
>> We have added sysfs bin_attribute 'fw_dump' in qla4xxx driver.
>> Here is patch for same: -
>> http://marc.info/?l=linux-scsi&m=133733192809849&w=2
>>
>>
>> In this patch in function qla4_8xxx_sysfs_write_fw_dump() if we print
>> string coming in 'char *buf'
>> from sysfs attribute it contain value we echo on sysfs attribute
>>'fw_dump'
>> plus some garbage data.
>
>Why are you not using the built-in firmware interface the kernel
>provides you? What does it lack that you need here?
In this patch we are not trying to load firmware, Here we are trying to
collect
firmware dump in case of adapter firmware crash. The firmware dump is in
driver buffer
and we want to extract it at user space using the sysfs bin attribute.
This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
prev parent reply other threads:[~2012-05-23 8:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 5:38 Vikas Chaudhary
2012-05-23 6:17 ` gregkh
2012-05-23 8:55 ` Vikas Chaudhary [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CBE2A210.EF14%vikas.chaudhary@qlogic.com \
--to=vikas.chaudhary@qlogic.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=gregkh@linuxfoundation.org \
--cc=lalit.chandivade@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=ravi.anand@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®