From: Borislav Petkov <bp@amd64.org>
To: Chen Gong <gong.chen@linux.intel.com>
Cc: "Luck, Tony" <tony.luck@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
"bp@amd64.org" <bp@amd64.org>, "x86@kernel.org" <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] x86: auto poll/interrupt mode switch for CMC to stop CMC storm
Date: Thu, 24 May 2012 08:00:16 +0200 [thread overview]
Message-ID: <20120524060016.GB25344@aftab.osrc.amd.com> (raw)
In-Reply-To: <4FBD9BAA.7070902@linux.intel.com>
On Thu, May 24, 2012 at 10:23:38AM +0800, Chen Gong wrote:
> Hi, Boris, when I write these codes I don't care if it is specific for
> Intel or AMD.
Well, but I do care so that when you leave and start doing something
else, people after you can still read and maintain that code.
> I just noticed it should be general for x86 platform and all related
> codes are general too, which in mce.c, so I think it should be fine to
> place the codes in mce.c.
Are you kidding me? Only Intel has CMCI.
Now, if some other vendor needs correctable errors interrupt rate
throttling, they can carve it out, make it generic, and move it to mce.c.
Otherwise, it belongs in mce_intel.c. For the same reason AMD error
thresholding code belongs to mce_amd.c.
Jeez.
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
next prev parent reply other threads:[~2012-05-24 5:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 2:32 Chen Gong
2012-05-23 10:09 ` Thomas Gleixner
2012-05-23 17:01 ` Luck, Tony
2012-05-23 18:58 ` Thomas Gleixner
2012-05-23 20:53 ` Luck, Tony
2012-05-24 2:23 ` Chen Gong
2012-05-24 6:00 ` Borislav Petkov [this message]
2012-05-24 9:54 ` Chen Gong
2012-05-24 10:02 ` Thomas Gleixner
2012-05-24 10:01 ` Thomas Gleixner
2012-05-24 10:48 ` Borislav Petkov
2012-05-24 17:34 ` Borislav Petkov
2012-05-24 10:12 ` Thomas Gleixner
2012-05-24 16:27 ` Luck, Tony
2012-05-24 18:18 ` Thomas Gleixner
2012-05-23 10:11 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120524060016.GB25344@aftab.osrc.amd.com \
--to=bp@amd64.org \
--cc=gong.chen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®