From: Borislav Petkov <bp@alien8.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Borislav Petkov <bp@amd64.org>,
Chen Gong <gong.chen@linux.intel.com>,
"Luck, Tony" <tony.luck@intel.com>,
"x86@kernel.org" <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] x86: auto poll/interrupt mode switch for CMC to stop CMC storm
Date: Thu, 24 May 2012 19:34:05 +0200 [thread overview]
Message-ID: <20120524173405.GA6882@liondog.tnic> (raw)
In-Reply-To: <alpine.LFD.2.02.1205241146100.3231@ionos>
On Thu, May 24, 2012 at 12:01:13PM +0200, Thomas Gleixner wrote:
> Aside of that machine_check_poll is called from other places as
> well. So looking at mce_timer_start() which is surprisingly the timer
> callback:
>
> The poll timer rate is self adjusting to intervals down to HZ/100. So
> when you get into a state where the timer rate becomes lower than HZ/5
> we'll trigger that CMCI storm in software and queue work even on
> machines which do not support CMCI or have it disabled. Brilliant,
> isn't it?
>
> So that rate check belongs into intel_treshold_interrupt() and wants a
> intel specific callback in mce_start_timer() to undo it.
Ok, I see it now, it took me awhile with my slow brain. And the code is
not a walk in the park anyway, thanks Thomas for pointing this out.
--
Regards/Gruss,
Boris.
next prev parent reply other threads:[~2012-05-24 17:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 2:32 Chen Gong
2012-05-23 10:09 ` Thomas Gleixner
2012-05-23 17:01 ` Luck, Tony
2012-05-23 18:58 ` Thomas Gleixner
2012-05-23 20:53 ` Luck, Tony
2012-05-24 2:23 ` Chen Gong
2012-05-24 6:00 ` Borislav Petkov
2012-05-24 9:54 ` Chen Gong
2012-05-24 10:02 ` Thomas Gleixner
2012-05-24 10:01 ` Thomas Gleixner
2012-05-24 10:48 ` Borislav Petkov
2012-05-24 17:34 ` Borislav Petkov [this message]
2012-05-24 10:12 ` Thomas Gleixner
2012-05-24 16:27 ` Luck, Tony
2012-05-24 18:18 ` Thomas Gleixner
2012-05-23 10:11 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120524173405.GA6882@liondog.tnic \
--to=bp@alien8.de \
--cc=bp@amd64.org \
--cc=gong.chen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®