From: Peter De Schrijver <pdeschrijver@nvidia.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Russell King <linux@arm.linux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Mike Turquette <mturquette@ti.com>
Subject: Re: [RFC PATCH] clk: add extension API
Date: Thu, 31 May 2012 10:51:25 +0300 [thread overview]
Message-ID: <20120531075125.GL8026@tbergstrom-lnx.Nvidia.com> (raw)
In-Reply-To: <4FC5DFCF.1020606@codeaurora.org>
On Wed, May 30, 2012 at 10:52:31AM +0200, Stephen Boyd wrote:
> On 5/29/2012 2:58 AM, Peter De Schrijver wrote:
> > Add an extension API for clocks. This allows clocktypes to provide extensions
> > for features which are uncommon and cannot be easily mapped onto normal clock
> > framework concecpts. eg: resetting blocks, configuring clock phase etc.
>
> This seems rather generic. Why not add more specific APIs/concepts like
> clk_reset(), clk_set_phase(), etc.? If they don't map, maybe we should
> make them map.
>
Some of those might be very SoC specific. Eg OMAP doesn't need software
controlled modulereset. I don't think we should add a new function to the
clock framework for clock related features which only exist in a single
SoC or family. Ideally we could use inheritance to add methods to derived
clocktypes, but that's not really possible in C unfortunately.
Cheers,
Peter.
next prev parent reply other threads:[~2012-05-31 7:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-29 9:58 Peter De Schrijver
2012-05-30 8:52 ` Stephen Boyd
2012-05-30 19:40 ` Mike Turquette
2012-05-30 20:28 ` Stephen Boyd
2012-05-31 19:09 ` Mike Turquette
2012-05-31 3:29 ` Saravana Kannan
2012-05-31 8:23 ` Peter De Schrijver
2012-05-31 21:12 ` Saravana Kannan
2012-05-31 7:51 ` Peter De Schrijver [this message]
2012-05-31 8:18 ` Felipe Balbi
2012-05-31 8:31 ` Peter De Schrijver
2012-05-31 8:54 ` Felipe Balbi
2012-05-31 9:05 ` Peter De Schrijver
2012-05-31 9:26 ` Felipe Balbi
2012-05-31 9:43 ` Peter De Schrijver
2012-05-31 9:46 ` Felipe Balbi
2012-05-31 9:57 ` Peter De Schrijver
2012-05-31 10:01 ` Felipe Balbi
2012-05-31 12:50 ` Cousson, Benoit
2012-05-31 13:04 ` Mark Brown
2012-05-31 13:07 ` Cousson, Benoit
2012-05-31 13:11 ` Mark Brown
2012-05-31 12:00 ` Mark Brown
2012-05-31 9:04 ` Stephen Boyd
2012-05-31 9:10 ` Peter De Schrijver
2012-05-30 9:28 ` Rajendra Nayak
2012-05-31 19:19 ` Mike Turquette
2012-06-06 12:07 ` Peter De Schrijver
2012-05-31 16:42 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120531075125.GL8026@tbergstrom-lnx.Nvidia.com \
--to=pdeschrijver@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mturquette@ti.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®