mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter De Schrijver <pdeschrijver@nvidia.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
	Russell King <linux@arm.linux.org.uk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Mike Turquette <mturquette@ti.com>
Subject: Re: [RFC PATCH] clk: add extension API
Date: Thu, 31 May 2012 12:05:18 +0300	[thread overview]
Message-ID: <20120531090518.GR8026@tbergstrom-lnx.Nvidia.com> (raw)
In-Reply-To: <20120531085432.GK5377@arwen.pp.htv.fi>

> 
> What if a module needs two clocks and you drive the reset on both of the
> clocks ? What would happen ?
> 

Only 'leave clocks' have this reset method and a module can only have 1 of
them.

> > but then we would have the keep a list of IDs (1 per module) which the drivers
> > can use to call some tegra reset function which would in the end use registers
> > in the same memory area to cause a reset. (the registers controlling
> > modulereset are interleaved with those controlling the enable/disable of the
> > main moduleclock and bitpositions are identical)
> 
> Well, under a generic device-level API, you could just call an internal
> clk_reset() function because you know which clocks feed into which
> devices anyway. It could look something like:
> 
> on Tegra:
> 
> device_reset(dev)
> 	-> dev_pm_domain->reset()
> 		-> tegra_periph_reset()
> 

These methods are also needed internally by the powergating code.

> on OMAP:
> 
> device_reset(dev)
> 	-> dev_pm_domain->reset()
> 		-> omap_hwmod_reset()
> 
> 
> btw:
> 
> tegra_periph_reset(....)
> {
> 	tegra_periph_reset_assert(...);
> 	udelay(2);
> 	tegra_periph_reset_deassert(...);
> }

which uses the clockframework currently.

Cheers,

Peter.

  reply	other threads:[~2012-05-31  9:06 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-29  9:58 Peter De Schrijver
2012-05-30  8:52 ` Stephen Boyd
2012-05-30 19:40   ` Mike Turquette
2012-05-30 20:28     ` Stephen Boyd
2012-05-31 19:09       ` Mike Turquette
2012-05-31  3:29     ` Saravana Kannan
2012-05-31  8:23       ` Peter De Schrijver
2012-05-31 21:12         ` Saravana Kannan
2012-05-31  7:51   ` Peter De Schrijver
2012-05-31  8:18     ` Felipe Balbi
2012-05-31  8:31       ` Peter De Schrijver
2012-05-31  8:54         ` Felipe Balbi
2012-05-31  9:05           ` Peter De Schrijver [this message]
2012-05-31  9:26             ` Felipe Balbi
2012-05-31  9:43               ` Peter De Schrijver
2012-05-31  9:46                 ` Felipe Balbi
2012-05-31  9:57                   ` Peter De Schrijver
2012-05-31 10:01                     ` Felipe Balbi
2012-05-31 12:50             ` Cousson, Benoit
2012-05-31 13:04               ` Mark Brown
2012-05-31 13:07                 ` Cousson, Benoit
2012-05-31 13:11                   ` Mark Brown
2012-05-31 12:00         ` Mark Brown
2012-05-31  9:04     ` Stephen Boyd
2012-05-31  9:10       ` Peter De Schrijver
2012-05-30  9:28 ` Rajendra Nayak
2012-05-31 19:19   ` Mike Turquette
2012-06-06 12:07     ` Peter De Schrijver
2012-05-31 16:42 ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120531090518.GR8026@tbergstrom-lnx.Nvidia.com \
    --to=pdeschrijver@nvidia.com \
    --cc=balbi@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mturquette@ti.com \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®