mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: kvm@vger.kernel.org, avi@redhat.com, mtosatti@redhat.com
Cc: jan.kiszka@siemens.com, alex.williamson@redhat.com,
	linux-kernel@vger.kernel.org, yongjie.ren@intel.com
Subject: [PATCH] KVM: Use IRQF_ONESHOT for assigned device MSI interrupts
Date: Fri, 01 Jun 2012 10:16:19 -0600	[thread overview]
Message-ID: <20120601161521.26935.25606.stgit@bling.home> (raw)

The kernel no longer allows us to pass NULL for a hard interrupt
handler without IRQF_ONESHOT.  Should have been using this flag
anyway.

Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=43328

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---

 virt/kvm/assigned-dev.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/virt/kvm/assigned-dev.c b/virt/kvm/assigned-dev.c
index 01f572c..e804d14 100644
--- a/virt/kvm/assigned-dev.c
+++ b/virt/kvm/assigned-dev.c
@@ -347,7 +347,7 @@ static int assigned_device_enable_host_msi(struct kvm *kvm,
 
 	dev->host_irq = dev->dev->irq;
 	if (request_threaded_irq(dev->host_irq, NULL,
-				 kvm_assigned_dev_thread_msi, 0,
+				 kvm_assigned_dev_thread_msi, IRQF_ONESHOT,
 				 dev->irq_name, dev)) {
 		pci_disable_msi(dev->dev);
 		return -EIO;
@@ -375,7 +375,7 @@ static int assigned_device_enable_host_msix(struct kvm *kvm,
 	for (i = 0; i < dev->entries_nr; i++) {
 		r = request_threaded_irq(dev->host_msix_entries[i].vector,
 					 NULL, kvm_assigned_dev_thread_msix,
-					 0, dev->irq_name, dev);
+					 IRQF_ONESHOT, dev->irq_name, dev);
 		if (r)
 			goto err;
 	}


             reply	other threads:[~2012-06-01 16:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-01 16:16 Alex Williamson [this message]
2012-06-01 16:39 ` Jan Kiszka
2012-06-01 17:03   ` Alex Williamson
2012-06-01 17:14     ` Jan Kiszka
2012-06-01 17:59       ` Alex Williamson
2012-06-01 18:26         ` Jan Kiszka
2012-06-03  8:42           ` Avi Kivity
2012-06-04 11:21             ` Thomas Gleixner
2012-06-04 11:40               ` Jan Kiszka
2012-06-04 13:07                 ` Thomas Gleixner
2012-06-04 13:16                   ` Jan Kiszka
2012-06-04 13:22                     ` Thomas Gleixner
2012-06-08  7:47                 ` Michael S. Tsirkin
2012-06-08  7:55                   ` Jan Kiszka
2012-06-08  8:00                     ` Michael S. Tsirkin
2012-06-08  8:03                       ` Jan Kiszka
2012-06-08 14:39                 ` Michael S. Tsirkin
2012-06-08 14:50                   ` Jan Kiszka
2012-06-11 10:01                     ` Avi Kivity
2012-06-11 10:21                       ` Michael S. Tsirkin
2012-06-18  8:46                         ` Ren, Yongjie
2012-06-18 11:00                         ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120601161521.26935.25606.stgit@bling.home \
    --to=alex.williamson@redhat.com \
    --cc=avi@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=yongjie.ren@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®