From: Thomas Gleixner <tglx@linutronix.de>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Avi Kivity <avi@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"mtosatti@redhat.com" <mtosatti@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"yongjie.ren@intel.com" <yongjie.ren@intel.com>
Subject: Re: [PATCH] KVM: Use IRQF_ONESHOT for assigned device MSI interrupts
Date: Mon, 4 Jun 2012 15:07:58 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1206041458490.3086@ionos> (raw)
In-Reply-To: <4FCC9EAC.9090007@siemens.com>
On Mon, 4 Jun 2012, Jan Kiszka wrote:
> On 2012-06-04 13:21, Thomas Gleixner wrote:
> So this shortcut requires some checks before being applied to a specific
> MSI/MSI-X vector.
>
>
> Taking KVM aside, my general question remains if threaded MSI handlers
> of all devices really need to apply IRQF_ONESHOT though they should have
> no use for it.
In theory no, but we had more than one incident, where threaded irqs
w/o a primary handler and w/o IRQF_ONEHSOT lead to full system
starvation. Linus requested this sanity check and I think it's sane
and required.
In fact it's a non issue for MSI. MSI uses handle_edge_irq which does
not mask the interrupt. IRQF_ONESHOT is a noop for that flow handler.
Thanks,
tglx
next prev parent reply other threads:[~2012-06-04 13:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-01 16:16 Alex Williamson
2012-06-01 16:39 ` Jan Kiszka
2012-06-01 17:03 ` Alex Williamson
2012-06-01 17:14 ` Jan Kiszka
2012-06-01 17:59 ` Alex Williamson
2012-06-01 18:26 ` Jan Kiszka
2012-06-03 8:42 ` Avi Kivity
2012-06-04 11:21 ` Thomas Gleixner
2012-06-04 11:40 ` Jan Kiszka
2012-06-04 13:07 ` Thomas Gleixner [this message]
2012-06-04 13:16 ` Jan Kiszka
2012-06-04 13:22 ` Thomas Gleixner
2012-06-08 7:47 ` Michael S. Tsirkin
2012-06-08 7:55 ` Jan Kiszka
2012-06-08 8:00 ` Michael S. Tsirkin
2012-06-08 8:03 ` Jan Kiszka
2012-06-08 14:39 ` Michael S. Tsirkin
2012-06-08 14:50 ` Jan Kiszka
2012-06-11 10:01 ` Avi Kivity
2012-06-11 10:21 ` Michael S. Tsirkin
2012-06-18 8:46 ` Ren, Yongjie
2012-06-18 11:00 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1206041458490.3086@ionos \
--to=tglx@linutronix.de \
--cc=alex.williamson@redhat.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=yongjie.ren@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome