From: Oleg Nesterov <oleg@redhat.com>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Anton Arapov <anton@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] uprobes: install_breakpoint() should fail if is_swbp_insn() == T
Date: Sat, 2 Jun 2012 20:21:58 +0200 [thread overview]
Message-ID: <20120602182158.GA21971@redhat.com> (raw)
In-Reply-To: <20120601183113.GA31771@redhat.com>
On 06/01, Oleg Nesterov wrote:
>
> while (more--) {
> info = kmalloc(sizeof(struct map_info), GFP_KERNEL);
> if (!info) {
> curr = ERR_PTR(-ENOMEM);
> goto out;
> }
> info->next = prev;
> prev = info;
> }
This should be "do ... while (--more)", otherwise it seems to work
and really helps.
I did the simple test under qemu. Currently uprobe_register() hangs
"forever" if the probed addr has 10000 mappings, I'have stopped qemu
after several minutes.
With the new code uprobe_register() needs 0.403s to complete.
We can also change build_map_info() to try GFP_NOWAIT | GFP_NOMEMALLOC
under i_mmap_mutex first, not sure this is really needed.
I'll write the changelog and send the patch...
Do you see any problems with this approach?
Oleg.
next prev parent reply other threads:[~2012-06-02 18:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 16:57 [PATCH 0/3] uprobes: misc minor changes Oleg Nesterov
2012-05-30 16:58 ` [PATCH 1/3] uprobes: install_breakpoint() should fail if is_swbp_insn() == T Oleg Nesterov
2012-05-30 17:28 ` Peter Zijlstra
2012-05-30 17:37 ` Srikar Dronamraju
2012-05-30 17:49 ` Peter Zijlstra
2012-05-30 17:54 ` Peter Zijlstra
2012-05-30 18:03 ` Peter Zijlstra
2012-05-30 18:04 ` Srikar Dronamraju
2012-05-30 18:21 ` Peter Zijlstra
2012-05-31 18:53 ` Oleg Nesterov
2012-06-01 15:53 ` Oleg Nesterov
2012-06-01 16:33 ` Srikar Dronamraju
2012-06-01 17:20 ` Oleg Nesterov
2012-06-01 18:31 ` Oleg Nesterov
2012-06-02 18:21 ` Oleg Nesterov [this message]
2012-06-01 16:47 ` Srikar Dronamraju
2012-06-01 18:38 ` Oleg Nesterov
2012-05-31 12:15 ` Peter Zijlstra
2012-05-31 12:54 ` Srikar Dronamraju
2012-05-30 16:58 ` [PATCH 2/3] uprobes: remove the unnecessary initialization in add_utask() Oleg Nesterov
2012-05-30 16:58 ` [PATCH 3/3] uprobes: simplify the usage of uprobe->pending_list Oleg Nesterov
2012-05-30 17:48 ` Srikar Dronamraju
2012-05-30 18:10 ` Oleg Nesterov
2012-05-30 18:23 ` Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120602182158.GA21971@redhat.com \
--to=oleg@redhat.com \
--cc=ananth@in.ibm.com \
--cc=anton@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome