mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Don Zickus <dzickus@redhat.com>
Cc: Jan Beulich <JBeulich@suse.com>,
	x86@kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86,nmi: Fix section mismatch warnings on 32-bit
Date: Tue, 5 Jun 2012 18:13:18 +0200	[thread overview]
Message-ID: <20120605161318.GA29751@merkur.ravnborg.org> (raw)
In-Reply-To: <20120605144734.GU32472@redhat.com>

On Tue, Jun 05, 2012 at 10:47:34AM -0400, Don Zickus wrote:
> On Tue, Jun 05, 2012 at 09:12:13AM +0100, Jan Beulich wrote:
> > >>> On 04.06.12 at 21:56, Don Zickus <dzickus@redhat.com> wrote:
> > > It was reported that compiling for 32-bit caused a bunch of section
> > > mismatch warnings:
> > > 
> > >  VDSOSYM arch/x86/vdso/vdso32-syms.lds
> > >   LD      arch/x86/vdso/built-in.o
> > >   LD      arch/x86/built-in.o
> > > WARNING: arch/x86/built-in.o(.data+0x5af0): Section mismatch in reference 
> > > from the variable
> > > test_nmi_ipi_callback_na.10451 to the function 
> > 
> > Did you check what this (compiler introduced) variable actually
> > represents? The problem clearly is that the compiler has no way
> > of knowing that data it generates referencing an __init function
> > would actually need to go into .init.data or alike.
> 
> I do not know enough about behind the scene compiler magic to track this
> down correctly.  So any insight/help is greatly appreciated. :-)

We register a function annotated __init. And the normal use of this register()
is for functions that survive the init phase.
So drop the __init annotation on the function we register and the mismatch is fixed.

	Sam

  parent reply	other threads:[~2012-06-05 16:13 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-04 19:56 Don Zickus
2012-06-05  8:12 ` Jan Beulich
2012-06-05 14:47   ` Don Zickus
2012-06-05 15:42     ` Jan Beulich
2012-06-05 18:35       ` Don Zickus
2012-06-06 11:14         ` Jan Beulich
2012-06-06 14:03           ` Don Zickus
2012-06-06 15:45             ` Ingo Molnar
2012-06-06 18:28               ` Don Zickus
2012-06-07  7:43             ` Li Zhong
2012-06-07 12:48               ` Don Zickus
2012-06-08 20:51                 ` Don Zickus
2012-06-11  1:36                   ` Zhong Li
2012-06-11  8:19                   ` Ingo Molnar
2012-06-05 16:13     ` Sam Ravnborg [this message]
2012-06-05 16:18       ` Jan Beulich
2012-06-05 17:22         ` Sam Ravnborg
2012-06-08  2:06           ` Don Zickus
2012-06-08  5:40             ` Sam Ravnborg
2012-06-06 14:05 Don Zickus
2012-06-06 21:22 ` Witold Baryluk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120605161318.GA29751@merkur.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=JBeulich@suse.com \
    --cc=dzickus@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®