* [PATCH 1/1] pinctrl: pinctrl-mxs: fix a compiling error
@ 2012-06-20 4:48 Dong Aisheng
2012-06-20 5:23 ` Shawn Guo
0 siblings, 1 reply; 3+ messages in thread
From: Dong Aisheng @ 2012-06-20 4:48 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-arm-kernel, linus.walleij, swarren, s.hauer, shawn.guo
From: Dong Aisheng <dong.aisheng@linaro.org>
The compiling error is:
drivers/pinctrl/pinctrl-mxs.c: In function 'mxs_dt_node_to_map':
drivers/pinctrl/pinctrl-mxs.c:140: error: implicit declaration of function 'free'
drivers/pinctrl/pinctrl-mxs.c:140: warning: incompatible implicit declaration of built-in function 'free'
It should be kfree.
Signed-off-by: Dong Aisheng <dong.aisheng@linaro.org>
---
drivers/pinctrl/pinctrl-mxs.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-mxs.c b/drivers/pinctrl/pinctrl-mxs.c
index afb50ee..4ba4636 100644
--- a/drivers/pinctrl/pinctrl-mxs.c
+++ b/drivers/pinctrl/pinctrl-mxs.c
@@ -137,7 +137,7 @@ static int mxs_dt_node_to_map(struct pinctrl_dev *pctldev,
free_group:
if (!purecfg)
- free(group);
+ kfree(group);
free:
kfree(new_map);
return ret;
--
1.7.0.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] pinctrl: pinctrl-mxs: fix a compiling error
2012-06-20 5:23 ` Shawn Guo
@ 2012-06-20 5:07 ` Dong Aisheng
0 siblings, 0 replies; 3+ messages in thread
From: Dong Aisheng @ 2012-06-20 5:07 UTC (permalink / raw)
To: Shawn Guo
Cc: Dong Aisheng-B29396, linux-kernel, linux-arm-kernel,
linus.walleij, swarren, s.hauer, Guo Shawn-R65073
On Wed, Jun 20, 2012 at 01:23:15PM +0800, Shawn Guo wrote:
> On Wed, Jun 20, 2012 at 12:48:37PM +0800, Dong Aisheng wrote:
> > From: Dong Aisheng <dong.aisheng@linaro.org>
> >
> > The compiling error is:
> > drivers/pinctrl/pinctrl-mxs.c: In function 'mxs_dt_node_to_map':
> > drivers/pinctrl/pinctrl-mxs.c:140: error: implicit declaration of function 'free'
> > drivers/pinctrl/pinctrl-mxs.c:140: warning: incompatible implicit declaration of built-in function 'free'
> > It should be kfree.
> >
>
> Already fixed by Fabio.
>
> http://git.kernel.org/?p=linux/kernel/git/linusw/linux-pinctrl.git;a=commit;h=14e1e9f5cadb7cff3a2846c27cc1b9c8f207ee18
>
Sorry, missed it.
Regards
Dong Aisheng
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] pinctrl: pinctrl-mxs: fix a compiling error
2012-06-20 4:48 [PATCH 1/1] pinctrl: pinctrl-mxs: fix a compiling error Dong Aisheng
@ 2012-06-20 5:23 ` Shawn Guo
2012-06-20 5:07 ` Dong Aisheng
0 siblings, 1 reply; 3+ messages in thread
From: Shawn Guo @ 2012-06-20 5:23 UTC (permalink / raw)
To: Dong Aisheng
Cc: linux-kernel, linux-arm-kernel, linus.walleij, swarren, s.hauer,
shawn.guo
On Wed, Jun 20, 2012 at 12:48:37PM +0800, Dong Aisheng wrote:
> From: Dong Aisheng <dong.aisheng@linaro.org>
>
> The compiling error is:
> drivers/pinctrl/pinctrl-mxs.c: In function 'mxs_dt_node_to_map':
> drivers/pinctrl/pinctrl-mxs.c:140: error: implicit declaration of function 'free'
> drivers/pinctrl/pinctrl-mxs.c:140: warning: incompatible implicit declaration of built-in function 'free'
> It should be kfree.
>
Already fixed by Fabio.
http://git.kernel.org/?p=linux/kernel/git/linusw/linux-pinctrl.git;a=commit;h=14e1e9f5cadb7cff3a2846c27cc1b9c8f207ee18
Regards,
Shawn
> Signed-off-by: Dong Aisheng <dong.aisheng@linaro.org>
> ---
> drivers/pinctrl/pinctrl-mxs.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-mxs.c b/drivers/pinctrl/pinctrl-mxs.c
> index afb50ee..4ba4636 100644
> --- a/drivers/pinctrl/pinctrl-mxs.c
> +++ b/drivers/pinctrl/pinctrl-mxs.c
> @@ -137,7 +137,7 @@ static int mxs_dt_node_to_map(struct pinctrl_dev *pctldev,
>
> free_group:
> if (!purecfg)
> - free(group);
> + kfree(group);
> free:
> kfree(new_map);
> return ret;
> --
> 1.7.0.4
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-06-20 5:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-20 4:48 [PATCH 1/1] pinctrl: pinctrl-mxs: fix a compiling error Dong Aisheng
2012-06-20 5:23 ` Shawn Guo
2012-06-20 5:07 ` Dong Aisheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®