From: Oleg Nesterov <oleg@redhat.com>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Anton Arapov <anton@redhat.com>, Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] uprobes: __replace_page() should not use page_address_in_vma()
Date: Wed, 20 Jun 2012 15:47:51 +0200 [thread overview]
Message-ID: <20120620134750.GA11582@redhat.com> (raw)
In-Reply-To: <20120620120742.GK4629@linux.vnet.ibm.com>
On 06/20, Srikar Dronamraju wrote:
>
> > -static int __replace_page(struct vm_area_struct *vma, struct page *page, struct page *kpage)
> > +static int __replace_page(struct vm_area_struct *vma, unsigned long addr,
> > + struct page *page, struct page *kpage)
>
> Could please update the comment above __replace_page to mention that it
> now takes addr as a parameter?
Will do, thanks.
Oleg.
next prev parent reply other threads:[~2012-06-20 13:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 19:46 [PATCH 0/5] uprobes: write_opcode() cleanups Oleg Nesterov
2012-06-19 19:46 ` [PATCH 1/5] uprobes: don't recheck vma/f_mapping in write_opcode() Oleg Nesterov
2012-06-19 19:47 ` [PATCH 2/5] uprobes: __replace_page() should not use page_address_in_vma() Oleg Nesterov
2012-06-20 12:07 ` Srikar Dronamraju
2012-06-20 13:47 ` Oleg Nesterov [this message]
2012-06-19 19:47 ` [PATCH 3/5] uprobes: kill write_opcode()->lock_page(new_page) Oleg Nesterov
2012-06-19 19:47 ` [PATCH 4/5] uprobes: cleanup and document write_opcode()->lock_page(old_page) Oleg Nesterov
2012-06-19 19:47 ` [PATCH 5/5] uprobes: write_opcode: alloc the new page outside of "retry" loop Oleg Nesterov
2012-06-20 12:29 ` Anton Arapov
2012-06-20 13:49 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120620134750.GA11582@redhat.com \
--to=oleg@redhat.com \
--cc=ananth@in.ibm.com \
--cc=anton@redhat.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome