From: Oleg Nesterov <oleg@redhat.com>
To: Anton Arapov <anton@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] uprobes: write_opcode: alloc the new page outside of "retry" loop
Date: Wed, 20 Jun 2012 15:49:11 +0200 [thread overview]
Message-ID: <20120620134911.GB11582@redhat.com> (raw)
In-Reply-To: <20120620122939.GA4018@bandura.brq.redhat.com>
On 06/20, Anton Arapov wrote:
>
> On Tue, Jun 19, 2012 at 09:47:59PM +0200, Oleg Nesterov wrote:
> > @@ -214,19 +214,18 @@ static int write_opcode(struct arch_uprobe *auprobe, struct mm_struct *mm,
> > struct vm_area_struct *vma;
> > int ret;
> >
> > -retry:
> > - /* Read the page with vaddr into memory */
> > - ret = get_user_pages(NULL, mm, vaddr, 1, 0, 0, &old_page, &vma);
> > - if (ret <= 0)
> > - return ret;
> > -
> > - ret = -ENOMEM;
> > new_page = alloc_page_vma(GFP_HIGHUSER_MOVABLE, vma, vaddr);
> Should we want NULL instead of vma in alloc_page_vma()? Or
> initialize vma with NULL...
OOPS. Thanks Anton, this should be fixed.
Oleg.
prev parent reply other threads:[~2012-06-20 13:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 19:46 [PATCH 0/5] uprobes: write_opcode() cleanups Oleg Nesterov
2012-06-19 19:46 ` [PATCH 1/5] uprobes: don't recheck vma/f_mapping in write_opcode() Oleg Nesterov
2012-06-19 19:47 ` [PATCH 2/5] uprobes: __replace_page() should not use page_address_in_vma() Oleg Nesterov
2012-06-20 12:07 ` Srikar Dronamraju
2012-06-20 13:47 ` Oleg Nesterov
2012-06-19 19:47 ` [PATCH 3/5] uprobes: kill write_opcode()->lock_page(new_page) Oleg Nesterov
2012-06-19 19:47 ` [PATCH 4/5] uprobes: cleanup and document write_opcode()->lock_page(old_page) Oleg Nesterov
2012-06-19 19:47 ` [PATCH 5/5] uprobes: write_opcode: alloc the new page outside of "retry" loop Oleg Nesterov
2012-06-20 12:29 ` Anton Arapov
2012-06-20 13:49 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120620134911.GB11582@redhat.com \
--to=oleg@redhat.com \
--cc=ananth@in.ibm.com \
--cc=anton@redhat.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome