[PATCH] cfq: reenable printing of sync/async queue info to blktrace cfqq log messages

[PATCH] cfq: reenable printing of sync/async queue info to blktrace cfqq log messages

[Josh Hunt]

Commit afc24d49c1e5dbeef745c1c1246f5ae6ebd97c71 made the printing of the
sync/async queue info only available when you have CONFIG_CFQ_GROUP_IOSCHED
enabled. This re-enables it for the case when you do not have that config
option set.

Signed-off-by: Josh Hunt <johunt@akamai.com>
---
 block/cfq-iosched.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index 3c38536..8307b67 100644
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -383,7 +383,9 @@ CFQ_CFQQ_FNS(wait_busy);
 
 #else
 #define cfq_log_cfqq(cfqd, cfqq, fmt, args...)	\
-	blk_add_trace_msg((cfqd)->queue, "cfq%d " fmt, (cfqq)->pid, ##args)
+	blk_add_trace_msg((cfqd)->queue, "cfq%d%c " fmt, (cfqq)->pid, \
+				cfq_cfqq_sync((cfqq)) ? 'S' : 'A', \
+				##args)
 #define cfq_log_cfqg(cfqd, cfqg, fmt, args...)		do {} while (0)
 #endif
 #define cfq_log(cfqd, fmt, args...)	\
-- 
1.7.0.4

Re: [PATCH] cfq: reenable printing of sync/async queue info to blktrace cfqq log messages

[Vivek Goyal]

On Mon, Jun 25, 2012 at 09:28:43PM -0700, Josh Hunt wrote:
> Commit afc24d49c1e5dbeef745c1c1246f5ae6ebd97c71 made the printing of the
> sync/async queue info only available when you have CONFIG_CFQ_GROUP_IOSCHED
> enabled. This re-enables it for the case when you do not have that config
> option set.
> 
> Signed-off-by: Josh Hunt <johunt@akamai.com>

Looks good to me. sync/async classification is independent of group
scheduling and printing the queue type in traces helps.

Acked-by: Vivek Goyal <vgoyal@redhat.com>

Thanks
Vivek

> ---
>  block/cfq-iosched.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
> index 3c38536..8307b67 100644
> --- a/block/cfq-iosched.c
> +++ b/block/cfq-iosched.c
> @@ -383,7 +383,9 @@ CFQ_CFQQ_FNS(wait_busy);
>  
>  #else
>  #define cfq_log_cfqq(cfqd, cfqq, fmt, args...)	\
> -	blk_add_trace_msg((cfqd)->queue, "cfq%d " fmt, (cfqq)->pid, ##args)
> +	blk_add_trace_msg((cfqd)->queue, "cfq%d%c " fmt, (cfqq)->pid, \
> +				cfq_cfqq_sync((cfqq)) ? 'S' : 'A', \
> +				##args)
>  #define cfq_log_cfqg(cfqd, cfqg, fmt, args...)		do {} while (0)
>  #endif
>  #define cfq_log(cfqd, fmt, args...)	\
> -- 
> 1.7.0.4