From: Andrew Morton <akpm@linux-foundation.org>
To: Rabin Vincent <rabin@rab.in>
Cc: Tejun Heo <tj@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: CONFIG_HAVE_MEMBLOCK_NODE -> CONFIG_HAVE_MEMBLOCK_NODE_MAP
Date: Fri, 29 Jun 2012 13:21:57 -0700 [thread overview]
Message-ID: <20120629132157.0f543593.akpm@linux-foundation.org> (raw)
In-Reply-To: <1341000877-12068-1-git-send-email-rabin@rab.in>
On Sat, 30 Jun 2012 01:44:37 +0530
Rabin Vincent <rabin@rab.in> wrote:
> 0ee332c14518699 ("memblock: Kill early_node_map[]") wanted to replace
> CONFIG_ARCH_POPULATES_NODE_MAP with CONFIG_HAVE_MEMBLOCK_NODE_MAP but
> ended up replacing one occurence with a reference to the non-existent
> symbol CONFIG_HAVE_MEMBLOCK_NODE.
>
> Signed-off-by: Rabin Vincent <rabin@rab.in>
> ---
> include/linux/mmzone.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index 2427706..1d0a9a3 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -773,7 +773,7 @@ extern int movable_zone;
>
> static inline int zone_movable_is_highmem(void)
> {
> -#if defined(CONFIG_HIGHMEM) && defined(CONFIG_HAVE_MEMBLOCK_NODE)
> +#if defined(CONFIG_HIGHMEM) && defined(CONFIG_HAVE_MEMBLOCK_NODE_MAP)
> return movable_zone == ZONE_HIGHMEM;
> #else
> return 0;
Huh. I wonder why nobody noticed.
next prev parent reply other threads:[~2012-06-29 20:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 20:14 Rabin Vincent
2012-06-29 20:21 ` Tejun Heo
2012-06-29 20:59 ` Rabin Vincent
2012-06-29 20:21 ` Andrew Morton [this message]
2012-06-29 20:23 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120629132157.0f543593.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rabin@rab.in \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®