mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Rabin Vincent <rabin@rab.in>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: CONFIG_HAVE_MEMBLOCK_NODE -> CONFIG_HAVE_MEMBLOCK_NODE_MAP
Date: Fri, 29 Jun 2012 13:23:33 -0700	[thread overview]
Message-ID: <20120629202333.GE21048@google.com> (raw)
In-Reply-To: <20120629132157.0f543593.akpm@linux-foundation.org>

On Fri, Jun 29, 2012 at 01:21:57PM -0700, Andrew Morton wrote:
> >  static inline int zone_movable_is_highmem(void)
> >  {
> > -#if defined(CONFIG_HIGHMEM) && defined(CONFIG_HAVE_MEMBLOCK_NODE)
> > +#if defined(CONFIG_HIGHMEM) && defined(CONFIG_HAVE_MEMBLOCK_NODE_MAP)
> >  	return movable_zone == ZONE_HIGHMEM;
> >  #else
> >  	return 0;
> 
> Huh.  I wonder why nobody noticed.

Well, the combination is 32bit + memory hotplug....

-- 
tejun

      reply	other threads:[~2012-06-29 20:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-29 20:14 Rabin Vincent
2012-06-29 20:21 ` Tejun Heo
2012-06-29 20:59   ` Rabin Vincent
2012-06-29 20:21 ` Andrew Morton
2012-06-29 20:23   ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120629202333.GE21048@google.com \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rabin@rab.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®