* [PATCH] ethernet: add export.h in davinci_cpdma.c
@ 2012-07-02 1:17 Kim, Milo
2012-07-02 1:33 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Kim, Milo @ 2012-07-02 1:17 UTC (permalink / raw)
To: arnd; +Cc: linux-omap, tony, linux-kernel, mathieu.poirier, davem
To remove warning messages about 'EXPORT_SYMBOL_GPL', include export header.
drivers/net/ethernet/ti/davinci_cpdma.c:280: warning: data definition has no type or storage class
drivers/net/ethernet/ti/davinci_cpdma.c:280: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/net/ethernet/ti/davinci_cpdma.c:280: warning: parameter names (without types) in function declaration
drivers/net/ethernet/ti/davinci_cpdma.c:326: warning: data definition has no type or storage class
drivers/net/ethernet/ti/davinci_cpdma.c:326: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/net/ethernet/ti/davinci_cpdma.c:326: warning: parameter names (without types) in function declaration
drivers/net/ethernet/ti/davinci_cpdma.c:357: warning: data definition has no type or storage class
drivers/net/ethernet/ti/davinci_cpdma.c:357: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/net/ethernet/ti/davinci_cpdma.c:357: warning: parameter names (without types) in function declaration
drivers/net/ethernet/ti/davinci_cpdma.c:428: warning: data definition has no type or storage class
drivers/net/ethernet/ti/davinci_cpdma.c:428: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/net/ethernet/ti/davinci_cpdma.c:428: warning: parameter names (without types) in function declaration
drivers/net/ethernet/ti/davinci_cpdma.c:452: warning: data definition has no type or storage class
drivers/net/ethernet/ti/davinci_cpdma.c:452: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/net/ethernet/ti/davinci_cpdma.c:452: warning: parameter names (without types) in function declaration
drivers/net/ethernet/ti/davinci_cpdma.c:537: warning: data definition has no type or storage class
drivers/net/ethernet/ti/davinci_cpdma.c:537: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/net/ethernet/ti/davinci_cpdma.c:537: warning: parameter names (without types) in function declaration
drivers/net/ethernet/ti/davinci_cpdma.c:555: warning: data definition has no type or storage class
drivers/net/ethernet/ti/davinci_cpdma.c:555: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/net/ethernet/ti/davinci_cpdma.c:555: warning: parameter names (without types) in function declaration
drivers/net/ethernet/ti/davinci_cpdma.c:704: warning: data definition has no type or storage class
drivers/net/ethernet/ti/davinci_cpdma.c:704: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/net/ethernet/ti/davinci_cpdma.c:704: warning: parameter names (without types) in function declaration
drivers/net/ethernet/ti/davinci_cpdma.c:788: warning: data definition has no type or storage class
drivers/net/ethernet/ti/davinci_cpdma.c:788: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/net/ethernet/ti/davinci_cpdma.c:788: warning: parameter names (without types) in function declaration
drivers/net/ethernet/ti/davinci_cpdma.c:816: warning: data definition has no type or storage class
drivers/net/ethernet/ti/davinci_cpdma.c:816: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/net/ethernet/ti/davinci_cpdma.c:816: warning: parameter names (without types) in function declaration
drivers/net/ethernet/ti/davinci_cpdma.c:877: warning: data definition has no type or storage class
drivers/net/ethernet/ti/davinci_cpdma.c:877: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/net/ethernet/ti/davinci_cpdma.c:877: warning: parameter names (without types) in function declaration
Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
---
drivers/net/ethernet/ti/davinci_cpdma.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c
index d614c37..3c1e423 100644
--- a/drivers/net/ethernet/ti/davinci_cpdma.c
+++ b/drivers/net/ethernet/ti/davinci_cpdma.c
@@ -19,6 +19,7 @@
#include <linux/err.h>
#include <linux/dma-mapping.h>
#include <linux/io.h>
+#include <linux/export.h>
#include "davinci_cpdma.h"
--
1.7.2.5
Best Regards,
Milo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ethernet: add export.h in davinci_cpdma.c
2012-07-02 1:17 [PATCH] ethernet: add export.h in davinci_cpdma.c Kim, Milo
@ 2012-07-02 1:33 ` David Miller
2012-07-02 1:34 ` David Miller
2012-07-02 2:07 ` Kim, Milo
0 siblings, 2 replies; 4+ messages in thread
From: David Miller @ 2012-07-02 1:33 UTC (permalink / raw)
To: Milo.Kim; +Cc: arnd, linux-omap, tony, linux-kernel, mathieu.poirier
From: "Kim, Milo" <Milo.Kim@ti.com>
Date: Mon, 2 Jul 2012 01:17:03 +0000
> To remove warning messages about 'EXPORT_SYMBOL_GPL', include export header.
...
> @@ -19,6 +19,7 @@
> #include <linux/err.h>
> #include <linux/dma-mapping.h>
> #include <linux/io.h>
> +#include <linux/export.h>
You aren't generating this patch against current sources, otherwise
you'd see that linux/module.h is included in this driver and therefore
the problem you ran into is not possible.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ethernet: add export.h in davinci_cpdma.c
2012-07-02 1:33 ` David Miller
@ 2012-07-02 1:34 ` David Miller
2012-07-02 2:07 ` Kim, Milo
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2012-07-02 1:34 UTC (permalink / raw)
To: Milo.Kim; +Cc: arnd, linux-omap, tony, linux-kernel, mathieu.poirier
Also, networking patches should always be CC:'d to netdev@vger.kernel.org
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] ethernet: add export.h in davinci_cpdma.c
2012-07-02 1:33 ` David Miller
2012-07-02 1:34 ` David Miller
@ 2012-07-02 2:07 ` Kim, Milo
1 sibling, 0 replies; 4+ messages in thread
From: Kim, Milo @ 2012-07-02 2:07 UTC (permalink / raw)
To: David Miller; +Cc: arnd, linux-omap, tony, linux-kernel, mathieu.poirier
> > @@ -19,6 +19,7 @@
> > #include <linux/err.h>
> > #include <linux/dma-mapping.h>
> > #include <linux/io.h>
> > +#include <linux/export.h>
>
> You aren't generating this patch against current sources, otherwise
> you'd see that linux/module.h is included in this driver and therefore
> the problem you ran into is not possible.
Oops ! This patch was generated based on the latest linux-omap tree, but similar code was already patched in linux-next tree.
Thanks for the notice.
Best Regards,
Milo -
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-07-02 2:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-02 1:17 [PATCH] ethernet: add export.h in davinci_cpdma.c Kim, Milo
2012-07-02 1:33 ` David Miller
2012-07-02 1:34 ` David Miller
2012-07-02 2:07 ` Kim, Milo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®