* [PATCH] usb: phy: Fix Kconfig dependency for Phy drivers
@ 2012-06-26 14:56 Alexandre Pereira da Silva
2012-06-26 15:49 ` Roland Stigge
2012-07-02 7:24 ` Felipe Balbi
0 siblings, 2 replies; 4+ messages in thread
From: Alexandre Pereira da Silva @ 2012-06-26 14:56 UTC (permalink / raw)
To: Roland Stigge
Cc: Alexandre Pereira da Silva, Greg Kroah-Hartman, Felipe Balbi,
linux-usb, linux-kernel
USB phy layer driver are only built if usb host is selected, but they
are used too by USB_GADGET drivers
Signed-off-by: Alexandre Pereira da Silva <aletes.xgr@gmail.com>
---
drivers/usb/Makefile | 2 +-
drivers/usb/phy/Kconfig | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/Makefile b/drivers/usb/Makefile
index c691eea..f5ed3d7 100644
--- a/drivers/usb/Makefile
+++ b/drivers/usb/Makefile
@@ -46,7 +46,7 @@ obj-$(CONFIG_USB_MICROTEK) += image/
obj-$(CONFIG_USB_SERIAL) += serial/
obj-$(CONFIG_USB) += misc/
-obj-$(CONFIG_USB) += phy/
+obj-$(CONFIG_USB_COMMON) += phy/
obj-$(CONFIG_EARLY_PRINTK_DBGP) += early/
obj-$(CONFIG_USB_ATM) += atm/
diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
index 3cfabcb..e7cf84f 100644
--- a/drivers/usb/phy/Kconfig
+++ b/drivers/usb/phy/Kconfig
@@ -2,11 +2,11 @@
# Physical Layer USB driver configuration
#
comment "USB Physical Layer drivers"
- depends on USB
+ depends on USB || USB_GADGET
config USB_ISP1301
tristate "NXP ISP1301 USB transceiver support"
- depends on USB
+ depends on USB || USB_GADGET
depends on I2C
help
Say Y here to add support for the NXP ISP1301 USB transceiver driver.
--
1.7.10
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: phy: Fix Kconfig dependency for Phy drivers
2012-06-26 14:56 [PATCH] usb: phy: Fix Kconfig dependency for Phy drivers Alexandre Pereira da Silva
@ 2012-06-26 15:49 ` Roland Stigge
2012-07-02 7:24 ` Felipe Balbi
1 sibling, 0 replies; 4+ messages in thread
From: Roland Stigge @ 2012-06-26 15:49 UTC (permalink / raw)
To: Alexandre Pereira da Silva
Cc: Greg Kroah-Hartman, Felipe Balbi, linux-usb, linux-kernel
On 06/26/2012 04:56 PM, Alexandre Pereira da Silva wrote:
> USB phy layer driver are only built if usb host is selected, but they
> are used too by USB_GADGET drivers
>
> Signed-off-by: Alexandre Pereira da Silva <aletes.xgr@gmail.com>
Acked-by: Roland Stigge <stigge@antcom.de>
> ---
> drivers/usb/Makefile | 2 +-
> drivers/usb/phy/Kconfig | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/Makefile b/drivers/usb/Makefile
> index c691eea..f5ed3d7 100644
> --- a/drivers/usb/Makefile
> +++ b/drivers/usb/Makefile
> @@ -46,7 +46,7 @@ obj-$(CONFIG_USB_MICROTEK) += image/
> obj-$(CONFIG_USB_SERIAL) += serial/
>
> obj-$(CONFIG_USB) += misc/
> -obj-$(CONFIG_USB) += phy/
> +obj-$(CONFIG_USB_COMMON) += phy/
> obj-$(CONFIG_EARLY_PRINTK_DBGP) += early/
>
> obj-$(CONFIG_USB_ATM) += atm/
> diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
> index 3cfabcb..e7cf84f 100644
> --- a/drivers/usb/phy/Kconfig
> +++ b/drivers/usb/phy/Kconfig
> @@ -2,11 +2,11 @@
> # Physical Layer USB driver configuration
> #
> comment "USB Physical Layer drivers"
> - depends on USB
> + depends on USB || USB_GADGET
>
> config USB_ISP1301
> tristate "NXP ISP1301 USB transceiver support"
> - depends on USB
> + depends on USB || USB_GADGET
> depends on I2C
> help
> Say Y here to add support for the NXP ISP1301 USB transceiver driver.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: phy: Fix Kconfig dependency for Phy drivers
2012-06-26 14:56 [PATCH] usb: phy: Fix Kconfig dependency for Phy drivers Alexandre Pereira da Silva
2012-06-26 15:49 ` Roland Stigge
@ 2012-07-02 7:24 ` Felipe Balbi
2012-07-02 9:49 ` Alexandre Pereira da Silva
1 sibling, 1 reply; 4+ messages in thread
From: Felipe Balbi @ 2012-07-02 7:24 UTC (permalink / raw)
To: Alexandre Pereira da Silva
Cc: Roland Stigge, Greg Kroah-Hartman, Felipe Balbi, linux-usb, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 869 bytes --]
Hi,
On Tue, Jun 26, 2012 at 11:56:48AM -0300, Alexandre Pereira da Silva wrote:
> USB phy layer driver are only built if usb host is selected, but they
> are used too by USB_GADGET drivers
>
> Signed-off-by: Alexandre Pereira da Silva <aletes.xgr@gmail.com>
> ---
> drivers/usb/Makefile | 2 +-
> drivers/usb/phy/Kconfig | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/Makefile b/drivers/usb/Makefile
> index c691eea..f5ed3d7 100644
> --- a/drivers/usb/Makefile
> +++ b/drivers/usb/Makefile
> @@ -46,7 +46,7 @@ obj-$(CONFIG_USB_MICROTEK) += image/
> obj-$(CONFIG_USB_SERIAL) += serial/
>
> obj-$(CONFIG_USB) += misc/
> -obj-$(CONFIG_USB) += phy/
> +obj-$(CONFIG_USB_COMMON) += phy/
I'm not sure this is the best solution. Should we introduce
CONFIG_USB_PHY for this ?
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: phy: Fix Kconfig dependency for Phy drivers
2012-07-02 7:24 ` Felipe Balbi
@ 2012-07-02 9:49 ` Alexandre Pereira da Silva
0 siblings, 0 replies; 4+ messages in thread
From: Alexandre Pereira da Silva @ 2012-07-02 9:49 UTC (permalink / raw)
To: balbi; +Cc: Roland Stigge, Greg Kroah-Hartman, linux-usb, linux-kernel
On Mon, Jul 2, 2012 at 4:24 AM, Felipe Balbi <balbi@ti.com> wrote:
> Hi,
>
> On Tue, Jun 26, 2012 at 11:56:48AM -0300, Alexandre Pereira da Silva wrote:
>> USB phy layer driver are only built if usb host is selected, but they
>> are used too by USB_GADGET drivers
>>
>> Signed-off-by: Alexandre Pereira da Silva <aletes.xgr@gmail.com>
>> ---
>> drivers/usb/Makefile | 2 +-
>> drivers/usb/phy/Kconfig | 4 ++--
>> 2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/usb/Makefile b/drivers/usb/Makefile
>> index c691eea..f5ed3d7 100644
>> --- a/drivers/usb/Makefile
>> +++ b/drivers/usb/Makefile
>> @@ -46,7 +46,7 @@ obj-$(CONFIG_USB_MICROTEK) += image/
>> obj-$(CONFIG_USB_SERIAL) += serial/
>>
>> obj-$(CONFIG_USB) += misc/
>> -obj-$(CONFIG_USB) += phy/
>> +obj-$(CONFIG_USB_COMMON) += phy/
>
> I'm not sure this is the best solution. Should we introduce
> CONFIG_USB_PHY for this ?
In my opinion, the right solution is to move the ISP1301 to the otg
dir, where it belongs and merge the duplicated code from lpc32xx_udc
and ohxi-nxp to it.
I suggest to leave this as is for now, as it's preventing the driver
to build in some configurations. Later, we can try to move this to the
right place.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-07-02 9:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-26 14:56 [PATCH] usb: phy: Fix Kconfig dependency for Phy drivers Alexandre Pereira da Silva
2012-06-26 15:49 ` Roland Stigge
2012-07-02 7:24 ` Felipe Balbi
2012-07-02 9:49 ` Alexandre Pereira da Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome