[PATCH 1/1] ACL: increase the #define XFS_ACL_MAX_ENTRIES to 128 The xfsprogs xfs_repair will have to be increased also if this is okay.

[PATCH 1/1] ACL: increase the #define XFS_ACL_MAX_ENTRIES to 128 The xfsprogs xfs_repair will have to be increased also if this is okay.

[Brad Arrington]

Signed-off-by: Brad Arrington <bradla8@yahoo.com>
---
 fs/xfs/xfs_acl.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_acl.h b/fs/xfs/xfs_acl.h
index 39632d9..716d4d2 100644
--- a/fs/xfs/xfs_acl.h
+++ b/fs/xfs/xfs_acl.h
@@ -22,7 +22,7 @@ struct inode;
 struct posix_acl;
 struct xfs_inode;
 
-#define XFS_ACL_MAX_ENTRIES 25
+#define XFS_ACL_MAX_ENTRIES 128
 #define XFS_ACL_NOT_PRESENT (-1)
 
 /* On-disk XFS access control list structure */
-- 
1.7.10.4

Re: [PATCH 1/1] ACL: increase the #define XFS_ACL_MAX_ENTRIES to 128 The xfsprogs xfs_repair will have to be increased also if this is okay.

[Dave Chinner]

On Thu, Jul 05, 2012 at 01:33:11PM -0700, Brad Arrington wrote:
> 
> Signed-off-by: Brad Arrington <bradla8@yahoo.com>
> ---
>  fs/xfs/xfs_acl.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_acl.h b/fs/xfs/xfs_acl.h
> index 39632d9..716d4d2 100644
> --- a/fs/xfs/xfs_acl.h
> +++ b/fs/xfs/xfs_acl.h
> @@ -22,7 +22,7 @@ struct inode;
>  struct posix_acl;
>  struct xfs_inode;
>  
> -#define XFS_ACL_MAX_ENTRIES 25
> +#define XFS_ACL_MAX_ENTRIES 128

That's an on disk format change - you can't just increase it like
that without some kind of superblock feature bit to indicate that
the limit is 128 rather than 25 on that filesystem.

As it is, if we are going to change it, it will get changed to allow
the maximum number of ACLs an attribute can hold, not another
arbitrary number like 128....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com