From: Dan Carpenter <dan.carpenter@oracle.com>
To: Devendra Naga <devendra.aaru@gmail.com>
Cc: Mark Einon <mark.einon@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Francois Romieu <romieu@fr.zoreil.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging/et131x: remove memset for the TCB
Date: Thu, 12 Jul 2012 11:36:10 +0300 [thread overview]
Message-ID: <20120712083610.GE6056@mwanda> (raw)
In-Reply-To: <1342073368-11893-1-git-send-email-devendra.aaru@gmail.com>
On Thu, Jul 12, 2012 at 11:54:28AM +0545, Devendra Naga wrote:
> TCB has kcalloc' ed so no need to call memset again on it.
>
Gar... What about when this is called from et131x_adjust_link() and
et1310_disable_phy_coma()?
Really this changelog is annoying. Based on the changelog I was
expecting the kcalloc() to be in the same function but it wasn't.
So then I have to redo all your work and check every code path. You
could have said what the code paths were in your description so I
don't have to grovel through it all myself.
regards,
dan carpenter
next prev parent reply other threads:[~2012-07-12 8:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 6:09 Devendra Naga
2012-07-12 8:36 ` Dan Carpenter [this message]
2012-07-12 9:11 ` devendra.aaru
2012-07-12 8:49 ` Alan Cox
2012-07-12 9:07 ` devendra.aaru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120712083610.GE6056@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=devendra.aaru@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.einon@gmail.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®