From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Devendra Naga <devendra.aaru@gmail.com>
Cc: Mark Einon <mark.einon@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Francois Romieu <romieu@fr.zoreil.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging/et131x: remove memset for the TCB
Date: Thu, 12 Jul 2012 09:49:43 +0100 [thread overview]
Message-ID: <20120712094943.2aba6d33@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <1342073368-11893-1-git-send-email-devendra.aaru@gmail.com>
On Thu, 12 Jul 2012 11:54:28 +0545
Devendra Naga <devendra.aaru@gmail.com> wrote:
> TCB has kcalloc' ed so no need to call memset again on it.
>
> Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
> ---
> drivers/staging/et131x/et131x.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
> index 227fca9..5010894 100644
> --- a/drivers/staging/et131x/et131x.c
> +++ b/drivers/staging/et131x/et131x.c
> @@ -2131,8 +2131,6 @@ static void et131x_init_send(struct et131x_adapter *adapter)
>
> tx_ring->tcb_qhead = tcb;
>
> - memset(tcb, 0, sizeof(struct tcb) * NUM_TCB);
Its such a rarely used path with several entry points that it's probably
safer kept as is.
Alan
next prev parent reply other threads:[~2012-07-12 8:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 6:09 Devendra Naga
2012-07-12 8:36 ` Dan Carpenter
2012-07-12 9:11 ` devendra.aaru
2012-07-12 8:49 ` Alan Cox [this message]
2012-07-12 9:07 ` devendra.aaru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120712094943.2aba6d33@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=devel@driverdev.osuosl.org \
--cc=devendra.aaru@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.einon@gmail.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®