* [PATCH 01/90 v2] staging: comedi: comedidev.h: introduce comedi_to_pci_dev() helper
@ 2012-07-19 17:39 H Hartley Sweeten
0 siblings, 0 replies; only message in thread
From: H Hartley Sweeten @ 2012-07-19 17:39 UTC (permalink / raw)
To: Linux Kernel; +Cc: devel, abbotti, gregkh
Introduce a wrapper for to_pci_dev() to allow the comedi_pci_drivers
to store the pci_dev pointer in the comedi_device hw_dev variable and
retrieve it easily.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbot <abbotti@mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
v2: Ian Abbott pointed out that the dev->hw_dev needs to be checked
that it's non-NULL before passing it to to_pci_dev(). As Dan
Carpenter pointed out, the container_of() just does pointer math
with the offset. If you give it a NULL pointer it returns a
bogus pointer back.
drivers/staging/comedi/comedidev.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
index de8c99c..f713783 100644
--- a/drivers/staging/comedi/comedidev.h
+++ b/drivers/staging/comedi/comedidev.h
@@ -446,6 +446,11 @@ static inline void comedi_set_hw_dev(struct comedi_device *dev,
}
}
+static inline struct pci_dev *comedi_to_pci_dev(struct comedi_device *dev)
+{
+ return dev->hw_dev ? to_pci_dev(dev->hw_dev) : NULL;
+}
+
int comedi_buf_put(struct comedi_async *async, short x);
int comedi_buf_get(struct comedi_async *async, short *x);
--
1.7.11
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-07-19 17:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-19 17:39 [PATCH 01/90 v2] staging: comedi: comedidev.h: introduce comedi_to_pci_dev() helper H Hartley Sweeten
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome