Re: [PATCHv4 0/4] perf tool: Add new event group management

[Jiri Olsa <jolsa@redhat.com>]

On Fri, Jul 20, 2012 at 05:09:33PM +0900, Namhyung Kim wrote:
> Hi, Jiri
> 
> On Thu, 19 Jul 2012 23:53:53 +0200, Jiri Olsa wrote:
> > hi,
> > adding support for creating event groups based on the way they
> > are specified on the command line.
> >
> > This patchset adds the '{}' style grammar to express event group,
> > allowing so far only the 'event modifier' as group modifier.
> >
> > v4 changes:
> >   - group modifier updates events modifiers (not overwrite as in v3)
> >
> > Attached patches:
> >   perf, tool: Add support to parse event group syntax
> >   perf, tool: Add support to update event modifier
> >   perf, tool: Enable grouping logic for parsed events
> >   perf, test: Add automated tests for event group parsing
> >
> 
> Thanks for keeping working on this. You can add my
> 
>   Reviewed-by: Namhyung Kim <namhyung@kernel.org>
> 
> for all of the patches if you want.
> 

great, thanks!

> Btw, is it all of your user-space changes?

I have changes for the group leader sampling, which needs more testing..
also maybe some redo after I saw your hist changes.. ;)

jirka