Re: [PATCHv4 0/4] perf tool: Add new event group management

[Namhyung Kim <namhyung@kernel.org>]

Hi, Jiri

On Thu, 19 Jul 2012 23:53:53 +0200, Jiri Olsa wrote:
> hi,
> adding support for creating event groups based on the way they
> are specified on the command line.
>
> This patchset adds the '{}' style grammar to express event group,
> allowing so far only the 'event modifier' as group modifier.
>
> v4 changes:
>   - group modifier updates events modifiers (not overwrite as in v3)
>
> Attached patches:
>   perf, tool: Add support to parse event group syntax
>   perf, tool: Add support to update event modifier
>   perf, tool: Enable grouping logic for parsed events
>   perf, test: Add automated tests for event group parsing
>

Thanks for keeping working on this. You can add my

  Reviewed-by: Namhyung Kim <namhyung@kernel.org>

for all of the patches if you want.

Btw, is it all of your user-space changes?

Thanks,
Namhyung


> wbr,
> jirka
> ---
>  tools/perf/builtin-record.c         |   13 ++-
>  tools/perf/builtin-stat.c           |   13 ++-
>  tools/perf/builtin-test.c           |    8 +-
>  tools/perf/builtin-top.c            |   12 +--
>  tools/perf/util/evlist.c            |   20 ++---
>  tools/perf/util/evlist.h            |    3 +-
>  tools/perf/util/evsel.c             |   51 +++++++----
>  tools/perf/util/evsel.h             |   13 +--
>  tools/perf/util/parse-events-test.c |  303 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>  tools/perf/util/parse-events.c      |  104 +++++++++++++++++++---
>  tools/perf/util/parse-events.h      |    5 +-
>  tools/perf/util/parse-events.l      |    2 +
>  tools/perf/util/parse-events.y      |   93 +++++++++++++++++---
>  tools/perf/util/python.c            |    7 +-
>  14 files changed, 552 insertions(+), 95 deletions(-)