mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Vinayak Holikatti <vinholikatti@gmail.com>
Cc: James.Bottomley@hansenpartnership.com,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	patches@linaro.org, linux-samsung-soc@vger.kernel.org,
	arnd@linaro.org, girish.shivananjappa@linaro.org,
	saugata.das@linaro.org, vishak.g@samsung.com, venkat@linaro.org,
	k.rajesh@samsung.com, dsaxena@linaro.org,
	ilho215.lee@samsung.com, nala.la@samsung.com,
	sreekumar.c@samsung.com, Santosh Yaraganavi <santoshsy@gmail.com>
Subject: Re: [PATCH V3 1/4] [SCSI] drivers/scsi/ufs: Seggregate PCI Specific Code
Date: Wed, 1 Aug 2012 14:38:28 +0000	[thread overview]
Message-ID: <201208011438.28719.arnd@arndb.de> (raw)
In-Reply-To: <1343292170-2599-2-git-send-email-vinholikatti@gmail.com>

On Thursday 26 July 2012, Vinayak Holikatti wrote:

> -static void ufshcd_remove(struct pci_dev *pdev)
> +void ufshcd_remove(struct ufs_hba *hba)
>  {
> -	struct ufs_hba *hba = pci_get_drvdata(pdev);
> -
>  	/* disable interrupts */
>  	ufshcd_int_config(hba, UFSHCD_INT_DISABLE);
> -	free_irq(pdev->irq, hba);
>  
>  	ufshcd_hba_stop(hba);
>  	ufshcd_hba_free(hba);
>  
>  	scsi_remove_host(hba->host);
>  	scsi_host_put(hba->host);
> +}
> +EXPORT_SYMBOL(ufshcd_remove);

For driver internal symbols, you should always use "EXPORT_SYMBOL_GPL"
here.

	Arnd


  reply	other threads:[~2012-08-01 14:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-26  8:42 [PATCH V3 0/4] [SCSI] ufs: Adds glue drivers to ufshcd Vinayak Holikatti
2012-07-26  8:42 ` [PATCH V3 1/4] [SCSI] drivers/scsi/ufs: Seggregate PCI Specific Code Vinayak Holikatti
2012-08-01 14:38   ` Arnd Bergmann [this message]
2012-08-04 14:45     ` vinayak holikatti
2012-07-26  8:42 ` [PATCH V3 2/4] [SCSI] drivers/scsi/ufs: Separate PCI code into glue driver Vinayak Holikatti
2012-08-01 14:43   ` Arnd Bergmann
2012-07-26  8:42 ` [PATCH V3 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd Vinayak Holikatti
2012-07-26  8:42 ` [PATCH V3 4/4] [SCSI] ufs: Correct the expected data transfer size Vinayak Holikatti
2012-07-26 10:32 ` [PATCH V3 0/4] [SCSI] ufs: Adds glue drivers to ufshcd S, Venkatraman
2012-07-26 11:12   ` vinayak holikatti
2012-07-26 11:35     ` S, Venkatraman
2012-07-26 11:44       ` vinayak holikatti
2012-08-01 14:44 ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201208011438.28719.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=arnd@linaro.org \
    --cc=dsaxena@linaro.org \
    --cc=girish.shivananjappa@linaro.org \
    --cc=ilho215.lee@samsung.com \
    --cc=k.rajesh@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nala.la@samsung.com \
    --cc=patches@linaro.org \
    --cc=santoshsy@gmail.com \
    --cc=saugata.das@linaro.org \
    --cc=sreekumar.c@samsung.com \
    --cc=venkat@linaro.org \
    --cc=vinholikatti@gmail.com \
    --cc=vishak.g@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome